Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Welcome guide cannot be dismissed with Do Not Track enabled. #39641

Closed
kwight opened this issue Feb 24, 2020 · 4 comments · Fixed by #39846
Closed

Block Editor: Welcome guide cannot be dismissed with Do Not Track enabled. #39641

kwight opened this issue Feb 24, 2020 · 4 comments · Fixed by #39846
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug

Comments

@kwight
Copy link
Contributor

kwight commented Feb 24, 2020

Originally reported by @scosgro in #39132 (comment).

The block editor's welcome guide will sometimes reappear on later views even if the user has dismissed it. This could be due to having the Do Not Track setting enabled (at least in Firefox).

73393156-d42ad980-42a0-11ea-9082-58c7b17fe8c9

#39132 (comment)
#39132 (comment)

@gwwar
Copy link
Contributor

gwwar commented Feb 24, 2020

For folks investigating, double check to see if this is an issue with the core Gutenberg project as well off of master. We'll want to file upstream too if it is an issue.

We can of course fix this ahead of core if so.

Offhand I think we store the preference in browser storage so localStorage or indexedDB, though I wouldn't be surprised if it had moved to user preferences.

@Addison-Stavlo
Copy link
Contributor

Offhand I think we store the preference in browser storage

This is how it currently works.

We can of course fix this ahead of core if so.
...though I wouldn't be surprised if it had moved to user preferences.

There is an open-issue to make this an account-wide setting. #39320 - a PR and Diff has been merged to support the infrastructure for this #38511 with a custom dotcom Welcome Guide. However, the functionality has not been launched as it was recommended to wait for design to come up with custom content for the dotcom version.

One option would be to essentially copy the core welcome-guide content into our version and launch it that way in the meantime. However, when this launches the welcome guide will pop up for every user that loads the editor (once, on their first time loading it after the launch). This is one reason we were waiting on custom dotcom content, but if we really need to fix this sooner rather than later then launching with a copy of core's content could be an option.

@yamphoenix
Copy link

The user has requested to turn off the block editor popup in this ticket also - #2699828-zen

@noahtallen
Copy link
Member

The welcome guide will become an account-wide option within the next day or two when the FSE plugin is synced with wpcom. This means if the user dismisses the modal once, they should not see it again for any site (unless they manually bring the welcome guide back up through the options).

Screen Shot 2020-03-03 at 1 21 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants