Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberFormat should support blank "thousandsSep" #39881

Open
beaucollins opened this issue Mar 4, 2020 · 1 comment
Open

numberFormat should support blank "thousandsSep" #39881

beaucollins opened this issue Mar 4, 2020 · 1 comment

Comments

@beaucollins
Copy link
Contributor

beaucollins commented Mar 4, 2020

Steps to reproduce

cd path/to/wp-calypso`
npm run build
node
const { numberFormat } = require('./packages/i18n-calypso/cjs/');
numberFormat(9999, { thousandsSep: '', });

What I expected

Output of 9999.

What happened instead

Output of 9,999.

Browser / OS version

None/Mac OS 10.15.3

Screenshot / Video

image

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants