Jetpack Backup: rename “Activity” menu option to "Activity & Backups" Atomic and Jetpack-connected sites

[lancewillett]

Suggested by @hafizrahman (ref: p58i-8F7-p2)

Add a new menu item "Tools -> Backup" for Atomic and Jetpack-connected sites which links to the Activity Log page filtered to the backups content:

https://wordpress.com/activity-log/SITEURL?group=rewind

1. Makes finding backups easier for users (current flow: Go to Site Activity, click Activity Type, find Backups and Restores).
2. Backups are important and useful feature.
3. In the future, we could use the page to upsell sites into the Business or eCommerce plan.

[lancewillett]

Input from @folletto

If the task is to change the name from “Activity” to “Backups” in the menu:

• If it’s selective, some sites don’t have Backup — WordPress.com Simple — use “Activity” (no-backup) and “Activity & Backups” (yes-backup).
• When clicked and Backups are available for the site, pre-filter the page so it shows by default “Activity Type: Backups and Restores”.

[lancewillett]

After looking at this more, I believe the simplest possible change is this:

• Add new "Backups" menu item only for Atomic and Jetpack-connected sites
• The link should use ?group=rewind to pre-filter the Backups in the view
• Leave "Activity" menu item in place for all sites

Edit: This wasn't easier to do after all. 😄 Targeting the "Backups" link with selected status isn't possible because it shares the same path prefix as "Activity". I went with the original suggestion instead.

[folletto]

Let's start with that then! :)

[lancewillett]

@hafizrahman @folletto #40113 is ready to review and test.

[lancewillett]

Worth discussing if the label change will require a lot of documentation and screenshot changes for Happiness Engineers.

Either way we'll give the Atomic Guild a heads-up.

[jeherve]

Should we consider updating the Masterbar as well? It is enabled by default on all Atomic sites, and cannot be disabled:

This can be done here:
https://github.com/Automattic/jetpack/blob/1364e8049ccd517132ef466d609d028d91dc7219/modules/masterbar/masterbar.php#L892

We already have Atomic-only things in that file:
https://github.com/Automattic/jetpack/blob/1364e8049ccd517132ef466d609d028d91dc7219/modules/masterbar/masterbar.php#L1261

[lancewillett]

@jeherve I'd like to remove that entire menu system for all WordPress.com sites. It's too difficult to maintain, and the design is now stale.

[lancewillett]

Two follow-up next actions as improvements next time this feature is worked on.

1. Activity & Backups: add a simple guide to highlight how to change the filter #40151 — Activity & Backups: add a simple guide to highlight how to change the filter
2. Activity & Backups: verify empty state is logical and helpful to explain how Backups work #40150 — Activity & Backups: verify empty state is logical and helpful to explain how Backups work