Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: do we still need the 'header cake'? #44321

Open
rickybanister opened this issue Jul 21, 2020 · 1 comment
Open

Navigation: do we still need the 'header cake'? #44321

rickybanister opened this issue Jul 21, 2020 · 1 comment

Comments

@rickybanister
Copy link

Currently secondary level pages (mostly) use the headerCake pattern to provide a 'back' link and a page title. It is intended to take up the same space of the sectionNav, to provide a seamless transition when navigating to deeper pages. However, since adding top-level page titles that is no longer the case (there are no page titles on secondary pages so there's a jump).

image

What do folks think about moving to a pattern like this:

image

The back link aligns with the site switcher, the header would align with the site card, and the rest of the content with the rest of the sidebar. If the sidebar changes we'd have to rethink the grid obviously, but we'll cross that bridge later.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants