Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification - implement menu fallback experience #45487

Closed
getdave opened this issue Sep 9, 2020 · 1 comment · Fixed by #45836
Closed

Nav Unification - implement menu fallback experience #45487

getdave opened this issue Sep 9, 2020 · 1 comment · Fixed by #45836
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@getdave
Copy link
Contributor

getdave commented Sep 9, 2020

This is a Sub Issue of #45435.

If the menu data is to come from a API request then we need to consider what happens when that request fails.

Calypso's data layer has a built in retry mechanic, but ultimately we should have a fallback experience for any time that the API fails or the cache is empty.

@cathymcbride cathymcbride added [Type] Task [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Sep 10, 2020
@getdave
Copy link
Contributor Author

getdave commented Sep 21, 2020

@marekhrabe suggested that we save a static snapshot of the API endpoint's output and render from that immediately and then hydrate from fresh dynamic data as and when available.

@getdave getdave changed the title Decide on sidebar menu fallback experience Nav Unification - implement menu fallback experience Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants