Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headstart: /u unicode characters not handled properly #45763

Open
autumnfjeld opened this issue Sep 20, 2020 · 5 comments
Open

Headstart: /u unicode characters not handled properly #45763

autumnfjeld opened this issue Sep 20, 2020 · 5 comments

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Sep 20, 2020

I discovered this issue when trying to fix headstart annotations for Spanish (wp-content/lib/headstart/annotations/es.json) and I needed to include the phrase "dirección de correo electrónico" in a block attribute. The Spanish ó came out as unicode charactere 00f3n.

Then I tried using the phrases "direcci\u00f3nn de correo electr\u00f3nnico" and then tried a number of variations of the unicode escape \u00f3n and \\u00f3n. Nothing worked, I was never able to produce the result I needed, meaning I could not get the correct Spanish letter to appear in the block.

Screen Shot 2020-09-15 at 14 59 08
Screen Shot 2020-09-15 at 15 03 27

Steps to reproduce

You can choose any language, but I'll go with Spanish for this example.

  1. Edit wp-content/lib/headstart/annotations/es.json -- edit a block that has block attributes, such as "submitButtonText" or "subscribePlaceholder" and input "dirección".

  2. From your terminal run headstart (PCYsg-7cr-p2): wp headstart run --url=YOURSITE.wordpress.com --user=YOURUSER --theme=pub/maywood --locale=es

  3. Then view the home page (or relevant page) of your site via the visual Editor and see that the Spanish is not displayed properly in that block

What I expected

To use direcci\u00f3nn in the block attribute and see dirección in the visual block.

What happened instead

direcci00f3nn is displayed instead of the proper spanish word

@ramonjd
Copy link
Member

ramonjd commented Oct 5, 2020

@deBhal has been investigating this.

I propose that, if we haven't reached a conclusion on a fix (if indeed one exists), we create an issue in the relevant repo, and/or p2 about it and cc as many relevant folks as possible.

That might yield the next steps, or prompt another team to look at it.

@github-actions
Copy link

github-actions bot commented Apr 4, 2021

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@synora
Copy link
Contributor

synora commented Apr 23, 2021

@ramonjd I noticed this issue has gone stale. Can we close it out or does it need to remain open?

@ramonjd
Copy link
Member

ramonjd commented Apr 25, 2021

Thanks @synora
I don't think it's a pressing issue, so I think it's fine to close and reopen as necessary later.
I'll cc @autumnfjeld just in case.

@autumnfjeld
Copy link
Contributor Author

I think this was fixed, if memory serves me correctly @lsl or @deBhal fixed it. I searched for some breadcrumbs to prove that, but no luck.

@deBhal deBhal removed their assignment Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants