Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Billing Management: Make subscription settings read-only for non purchasers (3) #45838

Closed
michaeldcain opened this issue Sep 22, 2020 · 2 comments
Closed

Billing Management: Make subscription settings read-only for non purchasers (3) #45838

michaeldcain opened this issue Sep 22, 2020 · 2 comments
Assignees
@fditrapani
Labels
[Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. [Type] Task
Milestone
Site-level Billin...

Comments

@michaeldcain
Copy link
Member

michaeldcain commented Sep 22, 2020 •
edited
Loading

A site-level /purchases/ view was added in #45601. For non-purchasers, we should prevent them from being able to navigate to the subscription settings screen and include a notice at the top of the page about why they can't. A similar view can be seen on /plans/ for non-purchasers:

Screen Shot 2020-09-22 at 10 25 32 AM
@michaeldcain michaeldcain added [Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. [Type] Task labels Sep 22, 2020
@michaeldcain michaeldcain changed the title Billing Management: Prevent navigating to subscription settings when not the purchaser Billing Management: Prevent navigating to subscription settings when not the purchaser (3) Sep 22, 2020
@fditrapani
Copy link
Contributor

fditrapani commented Sep 28, 2020 •
edited
Loading

In addition to this, are we also thinking about making the subscription listing not clickable for non-purchasers?

@fditrapani fditrapani mentioned this issue Sep 29, 2020
Merged
@fditrapani
Copy link
Contributor

fditrapani commented Sep 29, 2020 •
edited
Loading

As an alternative, what if we hide the buttons like this (I created a PR for it: #45979):

image

I still need to update the notice on the screen if we're happy to move forward with this.

@fditrapani fditrapani self-assigned this Sep 29, 2020
@fditrapani fditrapani changed the title Billing Management: Prevent navigating to subscription settings when not the purchaser (3) Billing Management: Make subscription settings read-only for non purchasers (3) Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fditrapani fditrapani

Labels
[Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. [Type] Task
Projects
None yet
Milestone
Site-level Billing Management
Development

No branches or pull requests
2 participants
@michaeldcain @fditrapani