Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: CSS file needs linting attention #46108

Open
blackjackkent opened this issue Oct 1, 2020 · 4 comments
Open

Notifications: CSS file needs linting attention #46108

blackjackkent opened this issue Oct 1, 2020 · 4 comments

Comments

@blackjackkent
Copy link
Contributor

Steps to reproduce

  1. Attempt to commit any change to /apps/notifications/src/panel/boot/stylesheets/main.scss
  2. Commit process will throw up linting errors.

Screenshot / Video

image

@obenland
Copy link
Member

@ockham Not sure who the best person is to ping on this one, could you help redirect me if needed? Is there an auto-fixer script for this like phpcbf for PHP?

@ockham
Copy link
Contributor

ockham commented Jan 29, 2021

stylelint --fix should normally do the trick (but doesn't here). Reading the error messages, it seems unlikely that there are automated fixes for all of those. I'm not familiar with the scales set of lint rules, but @Automattic/team-calypso should be able to help here 🙂

@sarayourfriend
Copy link
Contributor

I'm fairly certain all of those should be hand fixed. They're not just spacing/formatting issues, they create a material change to the UI so they should not be automated. Each should be reviewed and intentionally approved as an OK change.

Alternatively, they could be ignored if the UI should not be changed in those ways.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants