Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT: Apply block upgrades #46269

Open
sirreal opened this issue Oct 8, 2020 · 2 comments
Open

SPT: Apply block upgrades #46269

sirreal opened this issue Oct 8, 2020 · 2 comments
Assignees
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Pri] Low [Status] Stale [Type] Janitorial [Type] Task

Comments

@sirreal
Copy link
Member

sirreal commented Oct 8, 2020

Some SPT (Starter/Single Page Template) blocks are out of date and apply migrations on every load. They should be updated at the source.

Related to #46268

Steps to reproduce

  1. Load the SPT page editor for a Simple site: /wp-admin/post-new.php?post_type=page
  2. Observe block successfully updated messages reported in the console.

You may want to filter console messages like Block successfully updated for

Example messages:

Block successfully updated for `core/paragraph` (Object).

New content generated by `save` function:

<p style="font-size:50px">Introduce yourself – who you are, what you do, and where you are.</p>

Content retrieved from post body:

<p style="font-size:50px;">Introduce yourself – who you are, what you do, and where you are.</p>

Context / Source

props: @fullofcaffeine (p1602108571422000-slack-C015AL3QL7M testin p7DVsv-9rP-p2)

@sirreal sirreal added [Type] Task Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Pri] Low labels Oct 8, 2020
@noahtallen noahtallen self-assigned this Oct 20, 2020
@noahtallen
Copy link
Member

noahtallen commented Oct 20, 2020

Now that #46268 has been fixed, I took a look at this. I think nearly all of these issues come down to this:

+ font-size:50px
- font-size:50px;

Basically every inline CSS attribute currently has semicolons at the end, but in a newer update, I guess it removes them.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin [Pri] Low [Status] Stale [Type] Janitorial [Type] Task
Projects
None yet
Development

No branches or pull requests

3 participants