Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Size selector missing #47302

Open
mcampal opened this issue Nov 10, 2020 · 5 comments
Open

Image Size selector missing #47302

mcampal opened this issue Nov 10, 2020 · 5 comments
Labels
[Pri] Normal Triaged To be used when issues have been triaged. [Type] Bug

Comments

@mcampal
Copy link
Collaborator

mcampal commented Nov 10, 2020

Steps to reproduce

  1. Upload a picture to a Simple site
  2. Upgrade it to a Business plan and activate Karuna theme
  3. Create an Image block with the uploaded picture

What I expected

Available ‘Image Size’ selector on the Image Block properties when editing a post or page

What happened instead

Only Image dimensions (width and height) fields are displayed but no dropdown image size selector

Browser / OS version

Chrome / Windows 10

Screenshot / Video

This capture shows a ‘pre-upgrade’ uploaded image on the user’s site:
ok_image_size_full_ok

This capture shows a ‘post-upgrade’ uploaded image on the user’s site:
no_image_size_full_ok

Context / Source

Please note that the dropdown image size selector comes back after reverting the site to a simple site.

@cathymcbride
Copy link
Contributor

Some additional discussion here: p9F6qB-64S-p2

@cathymcbride cathymcbride added [Pri] Normal [Type] Bug Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions labels Nov 11, 2020
@jeyip
Copy link
Contributor

jeyip commented Nov 13, 2020

This is a curious issue. I can verify the problem on the affected user's site, but I can't seem to reproduce it on a testing site.

  • I create a new simple site through https://wordpress.com/new
  • I select the initial theme to be Coutoire
  • I upload a ~400kb jpeg image to the simple site's media library
  • I upgrade the simple site to a business plan using store admin
  • I switch the theme to Karuna and activate it
  • I navigate to Posts > Add New Post
  • I add an image block and select the jpeg image I previously uploaded

I've tried it twice, and in both instances, I can still see the image size selector. 🤔

@mcampal or @galakhyati would you mind taking a look at the steps I've outlined about how I'm reproducing the problem? Is there anything different from how either of you are replicating the issue?

@galakhyati
Copy link

The Image Size option is not showing for the images that were existing on the page/post while the site was simple: https://d.pr/v/HF7WVg/dUSpizYvO8

So the only missing steps from the ones you followed was to add an image on a page/post while the site was on a simple site, not just uploaded to the media.

Now if you add another image on the atomic site, it shows the Image Size option: https://d.pr/v/RZEspI/4qP7G55OMf

So basically the existing images on an atomic site is not showing the Image Size option. Hope that helps, please ping me if need any further help in replicating the issue.

@jeyip jeyip added [Pri] Low [Pri] Normal and removed [Pri] Normal Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Pri] Low labels Nov 17, 2020
@tjcafferkey
Copy link
Contributor

tjcafferkey commented Jan 20, 2021

I am able to replicate this issue by

  • Creating a page on a Simple Site and inserting an image > Save page
  • Upgrade Simple Site to Atomic
  • Edit the page, click the image that was inserted when your site was a Simple Site.

I suspect it has something to do with the transfer of data from Simple to Atomic sites, I found an article which explains more about this in the link at the bottom of this comment.

I can see that some of the settings on the image are missing after the site gets upgraded to Atomic. You can see in the below screenshot that after the site becomes Atomic, the image settings loses sizes which existed prior to the transfer. My knowledge falls short on where this loss of data actually happens.

Screenshot 2021-01-20 at 10 44 52

Some resources for anyone else looking into this:

  • Debugging Atomic Gutenberg locally: PCYsg-t5D-p2 (Skip to "Develop locally with Requestly")
  • Simple > Atomic site creation process: PCYsg-uAn-p2

@jeyip jeyip added the Triaged To be used when issues have been triaged. label Mar 4, 2021
@edwinho89
Copy link

36074230-hc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

6 participants