Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'automattic/launch' data-store: use siteId when getting/setting items #47328

Open
ciampo opened this issue Nov 11, 2020 · 0 comments
Open

'automattic/launch' data-store: use siteId when getting/setting items #47328

ciampo opened this issue Nov 11, 2020 · 0 comments
Labels
Data [Type] Enhancement
Projects
Focused Launch (inactive)

Comments

@ciampo
Copy link
Contributor

ciampo commented Nov 11, 2020

Context: see this conversation

We’ll need to use siteId when setting/getting all the items on the automattic/launch data-store for persistence to work correctly in Calypso.

The store would probably look similar to the Site data-store https://github.com/Automattic/wp-calypso/blob/master/packages/data-stores/src/site/reducer.ts#L74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Data [Type] Enhancement
Projects
Focused Launch (inactive)
  
🗃 Later (backlog)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ciampo @tjcafferkey @razvanpapadopol