Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Media & Text block image is not displayed if parent block has crop image toggled on #47680

Open
worldomonation opened this issue Nov 23, 2020 · 5 comments
Labels
Back to Basics Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug

Comments

@worldomonation
Copy link
Contributor

worldomonation commented Nov 23, 2020

Steps to reproduce

  1. Starting at URL: https://wordpress.com/pages/
  2. Add new post.
  3. Add Media & Text block (parent).
  4. In the Media area, upload or select an existing image.
  5. In the Content area, remove the existing Paragraph block.
  6. Add Media & Text block in the Content area (child).
  7. In the Media area, upload or select an existing image.
  8. Open Block settings for the parent block.
  9. Under Media & Text Settings, toggle the option Crop image to fill entire column.

What I expected

Both child and parent Media & Text blocks continue to display the image on screen.

What happened instead

Child Media & Text block's inserted image disappears from view.

Browser / OS version

Browser: Firefox 84.0a1 (2020-11-12) (64-bit), Safari Version 14.0.1 (15610.2.11.51.10, 15610), Firefox Nightly 87.0a1
OS: macOS 10.15.7 19H2

Screenshot / Video

Crop image toggled ON for parent block.
Screen Shot 2020-11-23 at 11 55 04

Crop image toggled OFF for parent block.
Screen Shot 2020-11-23 at 11 55 19

Context / Source

Context: exploratory testing of Media & Text block. Issue found via #manual-testing.

@worldomonation worldomonation changed the title Nested Media & Text block image goes missing if parent block has crop image toggled on Nested Media & Text block image is not displayed if parent block has crop image toggled on Nov 23, 2020
@worldomonation
Copy link
Contributor Author

Checked and is remains reproducible.

Screen.Recording.2021-02-01.at.3.38.15.PM.mov

@inaikem inaikem added [Type] Bug Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. labels Feb 4, 2021
@inaikem
Copy link
Contributor

inaikem commented Feb 4, 2021

Triage: Confirmed. I cannot replicate on WPorg sites. The "dissappearing nested image" occurs no matter how the parent and child block images are aligned:


Direct video link.

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@worldomonation
Copy link
Contributor Author

Still reproducible on

Gutenberg: v11.6.0
CoBlocks: 2.10.1
Editing Toolkit: 3.16100
WP AMP: 2.0.5

@worldomonation
Copy link
Contributor Author

Adding low priority as this is quite a specific use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back to Basics Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants