Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some steps of the signup flow perform unexpected function calls #47834

Open
dzver opened this issue Nov 27, 2020 · 2 comments
Open

Some steps of the signup flow perform unexpected function calls #47834

dzver opened this issue Nov 27, 2020 · 2 comments
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Pri] Low [Type] Task

Comments

@dzver
Copy link
Member

dzver commented Nov 27, 2020

Steps to reproduce

  1. Starting at URL: /start/launch-site with a new site
  2. Select Free plan and Free domain

What I expected

  • To not run add to cart functions
  • To not fetch an empty cart from the server before adding items to it

What happened instead

Add to cart with empty parameters.

I'm not sure if that has any negative impact on the code but debugging it is confusing. I think adding some more ifs so that empty domains/plans don't go to the cart functions.

@cathymcbride cathymcbride added [Type] Task [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Pri] Low labels Dec 1, 2020
@razvanpapadopol
Copy link

I think @Automattic/shilling did some work recently on adding to cart functionality. Is this still an issue?

@sirbrillig
Copy link
Member

Add to cart with empty parameters.

Interesting! I'm not sure, but it sounds like this could have been related to the fix in #52560

I just did a quick test of this flow, and I do see that signup still fetches the cart twice (once on the first launch flow page, and once on the second page), although nothing is added to the cart, so I'm not sure if that means this issue is resolved or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Pri] Low [Type] Task
Projects
None yet
Development

No branches or pull requests

4 participants