Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans Grid: fix feature list items alignment #47858

Open
3 tasks
ciampo opened this issue Nov 30, 2020 · 1 comment
Open
3 tasks

Plans Grid: fix feature list items alignment #47858

ciampo opened this issue Nov 30, 2020 · 1 comment
Labels
Focused Launch Issues and PRs related to Focused Launch [Goal] New Onboarding previously called Gutenboarding [Pri] Low [Type] Bug

Comments

@ciampo
Copy link
Contributor

ciampo commented Nov 30, 2020

What

There are discrepancies between the feature lists items' layout of the free plan and the other plans

image

Acceptance Criteria

  • The svg icon and the text should be vertically centered/aligned
  • When the text breaks the line, it should go below the icon
  • Test the change in Focused Launch - Details View (PlansGrid is a table) and Gutenboarding (PlansGrid is an accordion)

Context

One way of achieving this behavior is to use display: flex; align-items: center on the list item element

@ciampo ciampo added this to the Focused Launch: Release milestone Nov 30, 2020
@tjcafferkey tjcafferkey added this to Backlog in Focused Launch (inactive) via automation Dec 15, 2020
@tjcafferkey tjcafferkey removed this from the Focused Launch: Release milestone Dec 15, 2020
@razvanpapadopol razvanpapadopol moved this from Backlog to Ready for development in Focused Launch (inactive) Dec 15, 2020
@razvanpapadopol razvanpapadopol added [Goal] New Onboarding previously called Gutenboarding Focused Launch Issues and PRs related to Focused Launch labels Dec 15, 2020
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focused Launch Issues and PRs related to Focused Launch [Goal] New Onboarding previously called Gutenboarding [Pri] Low [Type] Bug
Projects
Focused Launch (inactive)
  
⏭ Next (ready for development)
Development

No branches or pull requests

4 participants