Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans grid: copy changes after Monthly plans #49390

Closed
7 tasks done
ciampo opened this issue Jan 28, 2021 · 0 comments · Fixed by #49397
Closed
7 tasks done

Plans grid: copy changes after Monthly plans #49390

ciampo opened this issue Jan 28, 2021 · 0 comments · Fixed by #49397
Assignees
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Pri] Normal [Type] Task

Comments

@ciampo
Copy link
Contributor

ciampo commented Jan 28, 2021

What

While working on #48963, we had to re-use some existing text strings because the ones requested in the designs were not already translated

Why

We should open a new PR with the exact copy requested in the design, and merge it once the translations are available

A/C

  • PR should have the String freeze label, and be merged only when all translations are available
  • Toggle component: From "Pay monthly" / "Pay annually" to "Monthly" / "Annually"
  • Plan item / card (accordion variant)
    • From "billed annually" to "billed as %s annually" (since the price already has "/month")
    • From "per month, billed monthly" to "billed monthly" (since the price already has "/month")
  • Plan item / card (table variant): From "billed annually" to "per month, billed as %s annually"
  • Final checkout step of Step by Step flow: From "billed annually" to "per month, billed as %s annually"
@ciampo ciampo added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Pri] Normal [Type] Task labels Jan 28, 2021
@ciampo ciampo added this to the New Onboarding: Monthly plans milestone Jan 28, 2021
@ciampo ciampo self-assigned this Jan 28, 2021
@razvanpapadopol razvanpapadopol changed the title Plans grid: copy changes Plans grid: copy changes after Monthly plans Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Pri] Normal [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant