Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: if Jetpack Search is turned off, Instant Search should appear untoggled too #52404

Closed
bluefuton opened this issue Apr 29, 2021 · 1 comment · Fixed by #52631
Closed

Settings: if Jetpack Search is turned off, Instant Search should appear untoggled too #52404

bluefuton opened this issue Apr 29, 2021 · 1 comment · Fixed by #52631
Assignees
@kangzj
Labels
[Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. [Status] In Progress [Type] Bug

Comments

@bluefuton
Copy link
Contributor

Steps to reproduce the behavior

  1. On a site with a Jetpack Search plan purchased, go to Settings > General > Performance
  2. Click to deactivate Jetpack Search with "Improve built-in WordPress search performance." toggle

What I expected to happen

When I deactivate Jetpack Search, the Instant Search experience toggle should be untoggled too.

What actually happened

The Instant Search experience toggle remained on.

Context

Raised by @jinnypark in https://github.com/Automattic/jpop-issues/issues/6586.

Level of impact (Does it block purchases? Does it affect more than just one site?)

Low.

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent.

Screenshot / Video

Screen Shot 2021-04-29 at 16 47 21
@bluefuton bluefuton added [Type] Bug [Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. labels Apr 29, 2021
@bluefuton
Copy link
Contributor Author

The original reporter also noted that the language used on the main toggle could be clearer - perhaps just 'Enable Jetpack Search'.

@kangzj kangzj self-assigned this May 4, 2021
@kangzj kangzj mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kangzj kangzj

Labels
[Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. [Status] In Progress [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetpack Search: instant search toggle should change with Jetpack Search toggle Automattic/wp-calypso
2 participants
@bluefuton @kangzj