Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post by Email: Images not uploaded to Atomic #53846

Closed
xpurichan opened this issue Jun 19, 2021 · 9 comments
Closed

Post by Email: Images not uploaded to Atomic #53846

xpurichan opened this issue Jun 19, 2021 · 9 comments
Labels
Jetpack [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@xpurichan
Copy link

Summary

When using post by email we can publish a blog post with text and images. This feature appears to be working fine on simple sites currently, but on Atomic sites only the text is published - no images are uploaded and there is no evidence (such as code) where the missing images should have been added.

I also tested using the special media+YOUR_SECRET_EMAIL@post.wordpress.com email address to upload images directly to my Atomic site's Media library and found that the images were not loaded.

The user who reported this says the always use this feature and that the issue began about two days ago (which would be around June 17th). I did note the update to Gutenberg 10.8.1 on their site on June 16th, but I also found that they have Gutenberg deactivated on their site (and Gutenberg was activated on my test site), so this may be irrelevant.

Steps to reproduce the behavior

  1. Choose an Atomic site and enable Post by Email: https://wordpress.com/support/post-by-email/#business-and-ecommerce-sites-with-plugins
  2. Create a new email and include a title as well as both text and image(s) in the body of the email
  3. After about a minute you can find the new post published to your Atomic site. Note that it includes your title and text, but no images.

What I expected to happen

Images added to post-by-email emails should be included in the published blog post.

What actually happened

Images are not added and the post is published as text only.

Context

User report in 4079323-hc

Browser / OS version

n/a

Is this specific to the applied theme? Which one?

n/a

Does this happen on simple or atomic sites or both?

Atomic only

Is there any console output or error text?

n/a

Level of impact (Does it block purchases? Does it affect more than just one site?)

Normal - effects all Atomic sites using the Post by Email feature.

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent

Screenshot / Video: If applicable, add screenshots to help explain your problem.

@xpurichan xpurichan added [Type] Bug User Report This issue was created following a WordPress customer report labels Jun 19, 2021
@xpurichan xpurichan added this to Needs triage in HE Triaging Board (new bugs) via automation Jun 19, 2021
@zdenys
Copy link
Contributor

zdenys commented Jun 19, 2021

I thought it was some AT issue first, but now I think it's the case here too: 4078331-zd-woothemes

@xpurichan
Copy link
Author

I received an automatic email reply from my site about the media attachment failure from the test on my AT site. It reads:

Some attachments were rejected from the following WordPress.com Post by Email:

https://DOMAINCOM/?p=148

- IMG_3820.jpeg - Unknown token
- IMG_3821.jpeg - Unknown token
- IMG_3822.jpeg - Unknown token

@zdenys zdenys added the Atomic label Jun 19, 2021
@JoshuaGoode
Copy link

JoshuaGoode commented Jun 19, 2021

This appears to be impacting self-hosted Jetpack sites as well. We should probably move this to Jetpack's repo or create an associated issue there.

Overall, this is a Jetpack feature that isn't being worked on right now: p9F6qB-6e2-p2#comment-35482

The Unknown token issue seems newer. Here are some previous internal reports.

  • p9F6qB-6e2-p2
  • p9F6qB-6Gj-p2

@Nic-Sevic
Copy link
Contributor

I went to open an issue in Jetpack but found a comparable one already open here: Automattic/jetpack#20132 (comment)

Added a comment there to tie the two together

@jeherve
Copy link
Member

jeherve commented Jun 21, 2021

cc @miguelxpn; I believe this may have been caused by your changes in D63003-code, maybe what you pass to Jetpack_Data::get_access_token compared to what was passed before.

Do you think you could take a look at this?

Thank you!

@miguelxpn
Copy link
Contributor

Jetpack_Data::get_access_token

I'll take a look!

@miguelxpn
Copy link
Contributor

I just deployed a fix and from what I could tell on my test site it's working now! If there's still some issue please let me know!

@jeherve
Copy link
Member

jeherve commented Jun 21, 2021

Thank you!

Closing this issue now, but this can be reopened later if the problem remains on some sites.


Internal reference: D63104-code

@jeherve jeherve closed this as completed Jun 21, 2021
HE Triaging Board (new bugs) automation moved this from Needs triage to Closed Jun 21, 2021
@renata-franco
Copy link

Another one here: 4668106-zd-woothemes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack [Type] Bug User Report This issue was created following a WordPress customer report
Development

No branches or pull requests

7 participants