Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright: theme-activate spec has clash #54854

Open
1 of 2 tasks
worldomonation opened this issue Jul 23, 2021 · 1 comment · Fixed by #55615
Open
1 of 2 tasks

Playwright: theme-activate spec has clash #54854

worldomonation opened this issue Jul 23, 2021 · 1 comment · Fixed by #55615

Comments

@worldomonation
Copy link
Contributor

worldomonation commented Jul 23, 2021

Details

The spec wp-theme__details-preview-activate.js in the Playwright suite has an isolation problem.

If there are two parallel instances Playwright e2e tests running at the same time:

  • execution A logs in and begins the test steps.
  • execution B logs in and begins the test steps, just a few seconds after execution A.
  • the test account has Twenty Twenty-One active, wants to activate Twenty-Twenty.

Execution A would get there first; it searches for and activates Twenty Twenty-One.
Execution B does not know this, as it is looking at the Themes gallery perhaps half a second after execution A. It clicks into Twenty Twenty-One expecting to find an 'Activate' button but instead it finds a Customize theme button.

This causes the step to register as a failure.

Checklist

Possible ideas

  • discontinue activate portion of the test?
  • create a new site for each instance of this test?

Related

No response

@worldomonation worldomonation added this to To do in Calypso & WPCOM Playwright Project via automation Jul 23, 2021
@worldomonation worldomonation linked a pull request Aug 24, 2021 that will close this issue
1 task
@worldomonation
Copy link
Contributor Author

Issue bypassed by disabling the steps that cause issues.

It may be possible to have a conditional skip in that if the test is run inside a Pre-Release environment, it executes the currently skipped steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant