Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Tour NEXT: Add E2E test to ensure sanity #57055

Open
2 tasks
chriskmnds opened this issue Oct 15, 2021 · 1 comment
Open
2 tasks

Welcome Tour NEXT: Add E2E test to ensure sanity #57055

chriskmnds opened this issue Oct 15, 2021 · 1 comment
Labels
Editor Welcome Project that is part of bigger scope to help new user's onboard to the WordPress Editor [Type] Task Welcome Tour

Comments

@chriskmnds
Copy link
Contributor

Details

As of #56867 the Welcome Tour will use reference elements on the page to move the step closer to it (or fallback to the default position - bottom left).

Let's add an E2E test to ensure the reference elements are present on the page. Maybe not much more involving than that, but might explore whether the tour renders near also.

Checklist

  • Changing one of the reference elements to an unknown selector should error.
  • (Optional?) Tour renders near the reference element when defined.

Related

No response

@chriskmnds chriskmnds added [Type] Task Editor Welcome Project that is part of bigger scope to help new user's onboard to the WordPress Editor Welcome Tour labels Oct 15, 2021
@chriskmnds chriskmnds added this to the Editor welcome tour NEXT milestone Oct 15, 2021
@worldomonation
Copy link
Contributor

FYI, something like this should not be an end to end test, but rather an integration level test. Unfortunately we do not have proper infrastructure in place yet for writing integration tests easily, but it is something the Quality Squad wants to do in the medium-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor Welcome Project that is part of bigger scope to help new user's onboard to the WordPress Editor [Type] Task Welcome Tour
Projects
None yet
Development

No branches or pull requests

2 participants