Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verticals: Resolve source of truth #57785

Closed
sixhours opened this issue Nov 8, 2021 · 2 comments
Closed

Verticals: Resolve source of truth #57785

sixhours opened this issue Nov 8, 2021 · 2 comments
Assignees

Comments

@sixhours
Copy link
Contributor

sixhours commented Nov 8, 2021

The spreadsheet and the current API differ significantly. The source of truth should be the current spreadsheet, which either needs to be made into its own API or merged with the existing API. Related to #57556

@sixhours
Copy link
Contributor Author

sixhours commented Nov 9, 2021

I compared the two lists with a spreadsheet diff and confirmed that all of the verticals listed in the spreadsheet are also listed in the current API.

Knowing this, I'll add a new column to the current API's source spreadsheet with priority information from the spreadsheet. Then we can look up verticals by priority rather than just ID.

@sixhours
Copy link
Contributor Author

sixhours commented Nov 9, 2021

We're not going to add priorities at this time (see #57556 (comment)), but the current API contains all the values from the secondary verticals list in the given spreadsheet, so it's safe to use. Marking this as resolved.

@sixhours sixhours closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant