-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blogger Flow: Video UI branch from starting-point screen #58262
Comments
@arthur791004 & @roo2 You should coordinate with Serenity Team, e.g. @kwight when you start work on this. Check what changes are in the works in the VideoUi or any other concerns. :) |
I propose a draft here. I think we should wait for something such as marking the video completed and showing the CTA on the footer once all of the videos are watched. One concern might be we should ensure the tracks events of the signup framework are fired correctly. Maybe they should expose some props let us to control some behavior of CTA. Or we only need the content of the video UI without the header and footer. And the cc @kwight |
We do have some props for this at the moment, but we're switching them to a simpler "context" prop that can be used to output any header/footer changes needed. I could see something like
I'd personally avoid this, to keep styling and layout as consistent as possible across the different eventual contexts for the component.
Is this something different from triggering the call to action? |
Close it as #59747 is shipped 🎉 |
Blogger Flow: Video UI
The stretch squad, aka Serenity, has just shipped a version of the Video UI, accessible through a button on My Home. Umbrella Issue: Implement the video course. #56888
We will be reusing their VideoUi component in the Blogger flow.
See their umbrella issue: Onboarding: Implement the video course. #56888
Acceptance Criteria & User Facing Requirements
Dev Checklist
Related
Blogger/Hero Flow Project Thread
Hero Flow: Write & Build intent screen #55603
Onboarding: Implement the video course. #56888
Demo of Video UI: pdgK6S-mD-p2
Implement the video course. #56888
The text was updated successfully, but these errors were encountered: