Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour Kit / Welcome Tour: Remove/refactor store access in tour rating component #60080

Open
1 task
chriskmnds opened this issue Jan 14, 2022 · 0 comments
Open
1 task

Comments

@chriskmnds
Copy link
Contributor

Details

We will be extracting tour rating into tour-kit for including as a last-step optional feature that variant implementors can enable. Tour rating is currently handled via a wp/data store access. I don't think Tour Kit should be registering a store right now, it's both a side effect and creates complexity when having multiple tour instances (it will need to deal with tour IDs, etc.).

Let's detach the store access from the respective component.

Checklist

  • Potentially pass callbacks to tour-kit, but connect via local state in tour rating, also as a fallback.

Related

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant