Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo installer: remove unused code #60349

Closed
2 of 3 tasks
allilevine opened this issue Jan 21, 2022 · 2 comments
Closed
2 of 3 tasks

Woo installer: remove unused code #60349

allilevine opened this issue Jan 21, 2022 · 2 comments
Assignees
Labels
[Type] Task Woop WooCommerce on Plans Pod

Comments

@allilevine
Copy link
Member

allilevine commented Jan 21, 2022

Details

We've added a new WooCommerce install flow so we can remove most of /my-sites/woocommerce (except the new landing page, WoopLandingPage).

Checklist

  • Check with Matt Sherman about removing required-plugins-install-view.jsx.
  • Test that the new flow starting at /woocommerce-installation/< site id > still works and doesn't throw errors.
  • Follow up: move the landing page out of /my-sites/woocommerce.
@allilevine allilevine added [Type] Task Woop WooCommerce on Plans Pod labels Jan 21, 2022
@lsl
Copy link
Contributor

lsl commented Jan 30, 2022

Check with Matt Sherman about removing required-plugins-install-view.jsx.

@mattsherman just in case, but this should be fine, the code is leftover from the old store on wpcom feature, its not in use and now that we've re-implemented the functionality under /start it can be deleted.

@allilevine
Copy link
Member Author

Closed by #60784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task Woop WooCommerce on Plans Pod
Projects
Status: 🎉 Done
Development

No branches or pull requests

2 participants