Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome Tour: onStepViewOnce callback has tourSteps as side-effect #60454

Open
escapemanuele opened this issue Jan 25, 2022 · 0 comments
Open

Welcome Tour: onStepViewOnce callback has tourSteps as side-effect #60454

escapemanuele opened this issue Jan 25, 2022 · 0 comments
Labels
Welcome Tour
Projects
Tourkit Development Board
Milestone
Tour Kit: Foundat...

Comments

@escapemanuele
Copy link
Contributor

escapemanuele commented Jan 25, 2022 •
edited

What

We introduced the onStepViewOnce callback in #59719.

In the Welcome Tour the callback function uses tourSteps, but that is a side-effect, as it is coming from the outer context. We should rethink this approach.
@escapemanuele escapemanuele added the [Type] Feature Request Feature requests label Jan 25, 2022
@escapemanuele escapemanuele added this to To do in Tourkit Development Board via automation Jan 25, 2022
@escapemanuele escapemanuele added this to the Tour Kit: Foundations milestone Jan 25, 2022
@escapemanuele escapemanuele removed the [Type] Feature Request Feature requests label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Welcome Tour
Projects
Tourkit Development Board
To do
Milestone
Tour Kit: Foundations
Development

No branches or pull requests
1 participant
@escapemanuele