Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux to Redux: Plans, Domains & Purchases #6144

Open
9 of 12 tasks
scruffian opened this issue Jun 20, 2016 · 5 comments
Open
9 of 12 tasks

Flux to Redux: Plans, Domains & Purchases #6144

scruffian opened this issue Jun 20, 2016 · 5 comments
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Stale [Type] Task

Comments

@scruffian
Copy link
Member

scruffian commented Jun 20, 2016

As outlined in #5046 we need to move the /plans, /purhcases and /domains to Redux. The work can be broken down like this:

Plans

Domains

  • Create QueryDomains component.
  • Stop using StoreConnection in domain management.
  • Remove domains flux stores.

Purchases

This issue is to investigate how much work this will be and how we will approach it.

@scruffian scruffian added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Jun 20, 2016
@scruffian scruffian added this to the Store: Maintenance milestone Jun 20, 2016
@drewblaisdell
Copy link
Contributor

drewblaisdell commented Jun 24, 2016

I added a checkbox to this and #5046 to add a purchases reducer.

Edit: Actually, the current Flux store is a reducer, so we can probably just move/update it.

@fabianapsimoes
Copy link
Contributor

@scruffian is "Remove plans flux stores" done or still pending?

Removing Purchases since we're done with the things under that label.

@fabianapsimoes fabianapsimoes removed the [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. label Jul 26, 2016
@scruffian
Copy link
Member Author

The last checkbox for plans is still pending...

@ghost ghost moved this from TODO to Stale? in Reduxify Flux: One Project to Rule Them All Sep 23, 2017
@ghost ghost changed the title Store: Moving from Flux to Redux Flux to Redux: Plans, Domains & Purchases Sep 24, 2017
@ghost ghost moved this from Stale? to TODO in Reduxify Flux: One Project to Rule Them All Sep 24, 2017
@ghost ghost self-assigned this Sep 24, 2017
@ghost ghost moved this from TODO to In Progress in Reduxify Flux: One Project to Rule Them All Sep 24, 2017
@jsnmoon jsnmoon unassigned ghost Jun 5, 2018
@jsnmoon jsnmoon moved this from In Progress to TODO in Reduxify Flux: One Project to Rule Them All Jun 5, 2018
@klimeryk
Copy link
Contributor

klimeryk commented Nov 9, 2020

Just FYI, there's already a QueryDomains-like component: https://github.com/Automattic/wp-calypso/blob/ba85297f6f21d08cd2c693040b8c2c3b2ac03185/client/components/data/query-site-domains/README.md So hopefully you can re-use it here. The old store is slowly being removed from domains code - glad to see this push! Please add @Automattic/cobalt to reviewers when you get this part - would love to help test and review 🙇

Edit: for reference, here are the two related PRs where I recently removed calls to this old store: #46418 and #47060

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Stale [Type] Task
Development

No branches or pull requests

5 participants