Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg - Margin controls on any block that involves layout #64438

Open
nagpai opened this issue Jun 8, 2022 · 19 comments
Open

Gutenberg - Margin controls on any block that involves layout #64438

nagpai opened this issue Jun 8, 2022 · 19 comments
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Page Layouts [Pri] Normal Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@nagpai
Copy link
Contributor

nagpai commented Jun 8, 2022

What

Blocks like Cover block, Media and text block , do not have the provision to adjust margins ( especially top and bottom margins ) . That leads to awkward white gaps in layouts

image

Blocks seem to have padding controls, but not margin.

Why

Without this control user has to depend on CSS which defeates the purpose of Gutenberg / FSE making things code free.

context : 35742471-hc

How

Try adding two cover blocks one below other and check the gap between the two.

@nagpai nagpai added the [Type] Feature Request Feature requests label Jun 8, 2022
@nagpai nagpai added this to Needs triage in HE Triaging Board (new bugs) via automation Jun 8, 2022
@nagpai nagpai added the Needs triage Ticket needs to be triaged label Jun 8, 2022
@kerrynicl kerrynicl added [Pri] Normal Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Page Layouts Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Jun 23, 2022
@kerrynicl
Copy link

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Updated main description of report - No

📌 FINDINGS/SCREENSHOTS/VIDEO
Markup 2022-06-23 at 09 09 58

📌 ACTIONS

  • Marked as Triaged for Quality Squad review
  • Feature request kept

@kerrynicl kerrynicl moved this from Needs triage to Triaged - Not yet prioritized in HE Triaging Board (new bugs) Jun 23, 2022
@nagpai
Copy link
Contributor Author

nagpai commented Jun 25, 2022

35898535-hc

Group blocks and paragraph blocks seem to have margin that cannot be controlled. Leading to awkward white spaces

image

@jordesign jordesign removed this from Triaged - Not yet prioritized in HE Triaging Board (new bugs) Jun 28, 2022
@nagpai
Copy link
Contributor Author

nagpai commented Jun 29, 2022

#35897506-hc

@carinapilar
Copy link

This seems to be similar to this other issue: #62782

As mentioned in the above comment, this also happens with Paragraph blocks, there's a gap on the top when using a paragraph with an image on the left (or on the right), for example:

ParagraphMargin

This doesn't happen with older themes. The above was with Twenty Twenty-Two, but it works with Hemingway Rewritten.

And the issue is with that same margin-block-start: var( --wp--style--block-gap ); mentioned on the GH link above.

@daria2303
Copy link

daria2303 commented Jun 29, 2022

One of the interactions about it: 5335066-zd-woothemes, had more in the past

@jordesign
Copy link
Contributor

It looks as though this is related to the block_gap functionality Gutenberg - but if I'm honest - I can't tell if/where it is being worked on and/or if this is a core issue - or something Themes need to opt in to.

@annezazu can you provide any insight to if the issue mentioned here is something being addressed in core? Potentially related issues I see are:

@annezazu
Copy link

👋🏼 Hey hey!

Blocks like Cover block, Media and text block , do not have the provision to adjust margins ( especially top and bottom margins ) . That leads to awkward white gaps in layouts

This specifically relates to Consistent Dimension controls . Going a step further though, alongside the dimensions, the problem remains that there needs to be an easier way to reset block gap (as you can see discussed in this issue about adding margin support to the group block).

Can you all gather a few more examples/share more here @jordesign? From there, I can see about opening an overall adjacent issue to the consistent dimension controls one as adding controls is just one piece of this.

@SaxonF
Copy link
Contributor

SaxonF commented Jul 14, 2022

Some adjacent thinking and exploration surrounding a more complete set of layout tools here

@Automattic Automattic deleted a comment from nagpai Jul 15, 2022
@jeherve
Copy link
Member

jeherve commented Jul 15, 2022

36074196-hc

Workaround - CSS

@github-actions
Copy link

github-actions bot commented Jul 15, 2022

Support References

This comment is automatically generated. Please do not edit it.

@annezazu
Copy link

@jordesign wanted to loop back on the above examples to see if we had a list of a few (3-4 ideally). No rush! Just looping back.

@devNigel
Copy link

I can see the similar gap between Group blocks, Headers and Footers. It is not possible to get rid of this space using editor features.

The gap is introduced by this CSS:

.wp-site-blocks > * + * {
    margin-block-start: 1.5rem;
}

Screenshot:

ovRWY2.png

User report: 36590943-hc

@Robertght
Copy link

@annezazu we might've lost this between the different channels. I've shared a list of my findings regarding similar experiences, but I'd say they don't all share the same factors here: pc4f5j-2dU-p2#comment-2805

Automattic/themes#6197
Automattic/themes#5578
Automattic/themes#3453 - > WordPress/gutenberg#28647
Automattic/themes#3159
Automattic/themes#5895

I'm not quite sure about this either, but looping in @pbking and @jeffikus for a second opinion on this.

@jordesign
Copy link
Contributor

@annezazu - it's been tricky to find interactions around this - as the wording/description of the issue when dealing with users is pretty varied and generic (around gaps between blocks) but anecdotally I know I've run into it...

A specific case (from empathy testing) is in the home page of Pe8rBq-2-p2 where there is no way to close the gap between Cover blocks within the Query/Loop of the layout.

@annezazu
Copy link

annezazu commented Sep 2, 2022

Thank you all for trying to gather more of these! Let's keep this open and see if more items/specific use cases come up for a feedback style issue. For now, there's far more momentum around consistent dimension controls that should help resolve the original issue described here: WordPress/gutenberg#43241 You can see what's planned for margin and blocks specifically here: WordPress/gutenberg#43243

@cuemarie
Copy link

Thanks for weighing in on this @annezazu and @jordesign ! Based on the advice above, I'm marking this as triaged to keep open and on our radar for now. Thanks!

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

@cuemarie cuemarie added this to Needs sorting in HE Cross-repo Watchlist via automation Sep 13, 2022
@cuemarie cuemarie moved this from Needs sorting to Gutenberg / WP Core in HE Cross-repo Watchlist Sep 13, 2022
@happychait
Copy link

User report 5759835-zen

@carinapilar
Copy link

This issue makes it impossible to create nice site sections with Cover blocks, which is a bummer. I was looking to create a shadow effect using 2 Cover blocks, to have a nice transition between blocks like this (example from a third-party theme not using Gutenberg):

shadow-effect

Since this result isn't possible to achieve with one Cover block and its Gradient option, using 2 Cover blocks also isn't possible because of this gap issue, since this would be the result:

space-between-cover-blocks

I would expect that adding zero to the blocks' padding would remove that space, but that doesn't happen.

@miksansegundo
Copy link
Collaborator

+1 for adding margin controls on template part blocks too because that would allow us to reset the global block gap as suggested in the issue WordPress/gutenberg#47637.

See how the template part block gets the global block gap and cannot be removed because of the lack of margin controls:

Screenshot 2566-06-02 at 12 10 03

For context, the padding controls were removed in Remove color, spacing, and layout options for Template Part block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Page Layouts [Pri] Normal Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Projects
HE Cross-repo Watchlist
Gutenberg / WP Core
Development

No branches or pull requests