Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify loading screens in all onboarding flows #64960

Closed
6 of 9 tasks
autumnfjeld opened this issue Jun 25, 2022 · 5 comments
Closed
6 of 9 tasks

Unify loading screens in all onboarding flows #64960

autumnfjeld opened this issue Jun 25, 2022 · 5 comments
Assignees
Labels
[Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Jun 25, 2022

Description

This issue may need cleanup/more definition and collaboration with other Create teams.

We need to unify the loading screens that users see in signup & onboarding (from the first account screen through to any of the FTM onboarding flows).

Per this P2 convo, pdDOJh-sJ-p2#comment-346, I pulled these problems:

  • From Goals screen, clicking “Hire our experts” (difm) : see interstitial screen says “Laying the foundations”
  • From Domains screen to Goals Scree: see “Applying Design” , user has not yet seen design step
  • Mismatch in loading UIs: the loading/progress bar shown between domains step and goals is different to the loading screen we see at the end of the flow

See design specs here: pbAok1-2RP-p2#loaders

image

image

image

Acceptance Criteria

Dev Tasks

  • Retrieve intent and currentStep value on Stepper's processing step
  • Improve DIFM flow loading screen ( Goals -> Hire our experts )
  • Improve loading screen from Domain -> Goals
  • Improve loading screen on /wooConfirm step of sell flow, it saying 'Laying the foundations' when navigate to /checkout
  • Improve loading screen on /wooConfirm step when data is loading
  • Improve loading screen on /importerWordpress to prevent overlapping with the onboarding progress bar on top of screen Onboarding progress bar #64586

Testing Instructions

  • Start with new account at /start
  • Go through each flow from the Goals screen to check consistency of screens (@autumnfjeld can help with testing)

Related

#65024

@bangank36
Copy link
Contributor

bangank36 commented Jul 14, 2022

I update dev tasks for tracking implementation progress

  • Retrieve intent and currentStep value on Stepper's processing step
  • Improve DIFM flow loading screen ( Goals -> Hire our experts )
  • Improve loading screen from Domain -> Goals
  • Improve loading screen on /wooConfirm step of sell flow, it saying 'Laying the foundations' when navigate to /checkout

@autumnfjeld
Copy link
Contributor Author

@bangank36 & @taipeicoder It might be a good idea to specify the tasks for each loading screen either as clear separate tasks in the issue description or create new separate git issues - so that multiple people could work on this if needed. If that makes sense......

@taipeicoder
Copy link
Contributor

@bangank36 could you provide ballpark estimates?

@bangank36
Copy link
Contributor

@bangank36 could you provide ballpark estimates?

Hi @taipeicoder, I am about to make it ready for review today, there is some issues with local enviroment, but thanks to your help i have got rid of them

@bangank36 bangank36 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 26, 2022
@bangank36
Copy link
Contributor

Closed as shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

No branches or pull requests

3 participants