Sites Management Dashboard: allow user to return to dashboard after clicking "New site" button

[p-jackson]

The "New site" button added in #65182 takes the user from the dashboard to the site creation flow. But the button in the top left of the flow that's supposed to return the user to where they came from isn't taking the user back to the dashboard.

The site creation flow may already support a query parameter that allows the back URL to be set, but I'm not sure.

Done is:

• When coming from the dashboard the back button label should say "Back to All My Sites" (which is what the link in the site switcher says)
• It should return the user to the sites dashboard.

[danielbachhuber]

@p-jackson In my testing, the user is taken back to /sites:

CleanShot.2022-07-08.at.07.58.33.mp4

Given /sites-dashboard will shortly become /sites, shouldn't we keep the current behavior?

Also, in my opinion, "Back to My Sites" makes more sense than "Back to All My Sites"...

[p-jackson]

Technically My Sites is the proper noun for the main Calypso area

But you make a good point, it does sort of work good enough at the moment. The confusion isn't helped by the fact the title of the dashboard is My Sites 😅

I wonder how well it works in other languages. Like, maybe the label is rendered using "Back to %s" and whatever we use consistently for My Sites in other languages might not be as generic as it is in English?

Maybe we should leave this ticket on the back burner for a bit to see whether the inconsistencies in the title get worked out, maybe as part of #65162? @SaxonF

[wojtekn]

I see we didn't agree about the final wording for the back link yet, but I went ahead and opened PR that lets users go back to the Sites Dashboard from the New Sites flow as this part is clear. We can adjust the link label later.

I think that "My Sites" makes sense there. I would treat "All" and "Back to" as words that describe the CTA target and "My Sites" as the CTA target:

• All "My Sites"
• Back to "My Sites"