Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optional) Pattern Assembler: Make a new preview component to preview the selected patterns #66786

Closed
5 tasks
arthur791004 opened this issue Aug 19, 2022 · 2 comments

Comments

@arthur791004
Copy link
Contributor

arthur791004 commented Aug 19, 2022

Description

We want to show the preview of the selected patterns and the user could easily know what their home page look like. We could re-use the <WebPreview /> component and make a new toolbar for it.

Screen Shot 2022-08-19 at 3 48 21 PM

7l53h5fxAUNjVRBQ82YFwn-fi-238%3A41198

Acceptance Criteria

Desktop

Mobile

UPDATE: we will not being creating a mobile version in this release. Please see pbxlJb-2ki-p2#user-facing-acceptance-criteria

  • The preview toolbar should be hidden

See pbxlJb-2gk-p2#mobile

Dev Tasks

  • TBD

Related

@autumnfjeld autumnfjeld transferred this issue from another repository Aug 21, 2022
@miksansegundo
Copy link
Collaborator

The team Cylon were recently working on the component <WebPreview> as part of LaunchPad v1. Here is a conversation about the changes.

@arthur791004 arthur791004 changed the title (Optional) Make a new preview component to preview the selected patterns (Optional) Pattern Assembler: Make a new preview component to preview the selected patterns Aug 25, 2022
@arthur791004
Copy link
Contributor Author

Close it via #67424 and we decided to re-use the existing layout of the device switcher. See 7l53h5fxAUNjVRBQ82YFwn-fi-256%3A42065

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants