Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Assembler: Show the main screen on "build-your-own-layout" step #66787

Closed
8 of 10 tasks
arthur791004 opened this issue Aug 19, 2022 · 2 comments
Closed
8 of 10 tasks
Assignees

Comments

@arthur791004
Copy link
Contributor

arthur791004 commented Aug 19, 2022

Description

We want to show the main screen on the new step, and it will include the title, description, "choose a header", "add a section", "choose a footer", and "Continue" button.
image

7l53h5fxAUNjVRBQ82YFwn-fi-238%3A41198

Please ignore the search bar here.

Acceptance Criteria

  • It will show "Choose a header", "Add a first section", and "Choose a footer" buttons at the beginning. If you have already selected a section, the "Add a first section" copy will change to "Add another section".
  • When you click on the "Choose a header", it will show the pattern selector, and all of the patterns should be related to the header (blockTypes: "core/template-part/header")
  • When you click on the "Add a first section" or "Add another section", it will show the pattern selector, and the header/footer-related patterns should be excluded.
  • When you click on the "Choose a footer", it will show the pattern selector, and all of the patterns should be related to the footer (blockTypes: "core/template-part/footer")
  • The selected pattern is added showing the pattern name in one line. If the pattern name is too long we will truncate it off using ... at the end + show the entire name via tooltip with title.
  • When you hover on the selected pattern, you will see the 3 action buttons as screenshot below
    Screen Shot 2022-08-19 at 4 26 03 PM
    • The first one is to re-order the section and it won't be shown on the header/footer pattern. When you click "up", the section will go up. When you click "down", the section will go down
    • The second one is to select another pattern. When you click on it, it will show the pattern selector again.
    • The last one is to remove the selected pattern

Note that we don't limit the number of selected sections.

Dev Tasks

Related

@arthur791004 arthur791004 changed the title Show the main screen on "build-your-own" layout step Show the main screen on "build-your-own-layout" step Aug 19, 2022
@autumnfjeld autumnfjeld transferred this issue from another repository Aug 21, 2022
@miksansegundo
Copy link
Collaborator

miksansegundo commented Aug 24, 2022

I have added the following acceptance criteria to consider the long pattern names:

  • The selected pattern is added showing the pattern name in one line. If the pattern name is too long we will truncate it off using ... at the end + show the entire name via tooltip with title.

@bangank36 bangank36 self-assigned this Aug 24, 2022
@arthur791004 arthur791004 changed the title Show the main screen on "build-your-own-layout" step Pattern Assembler: Show the main screen on "build-your-own-layout" step Aug 25, 2022
@miksansegundo miksansegundo self-assigned this Aug 31, 2022
@arthur791004
Copy link
Contributor Author

Close it via #66954 and we show the whitelisted patterns instead of filtering patterns by blockTypes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants