Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getLaunchPadUrl() utility function so Launchpad links never break again #70909

Open
danielbachhuber opened this issue Dec 7, 2022 · 1 comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. Sites [Type] Task

Comments

@danielbachhuber
Copy link
Contributor

Our 'Launch guide' link on the Sites page was broken for over a month because of #69561. Once we noticed the issue, it was fixed with #70885.

The underlying problem is that manually constructed URLs can be brittle. We should introduce a getLaunchPadUrl() utility function and use it throughout, so Launchpad pad links never break again.

Done is:

  • getLaunchpadUrl() is introduced in some appropriate location.
  • All links into the Launchpad use the utility function.
@danielbachhuber danielbachhuber added Sites [Type] Task [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. labels Dec 7, 2022
@danielbachhuber
Copy link
Contributor Author

Named routes would be even more awesome: p1670451405142289-slack-C03N25JPCE4

I think a utility function would still be useful in the interim, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. Sites [Type] Task
Projects
None yet
Development

No branches or pull requests

1 participant