Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Table of Contents: Block Error when nested inside columns on Simple sites #70913

Open
cuemarie opened this issue Dec 7, 2022 · 10 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Simple [Pri] Normal Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@cuemarie
Copy link

cuemarie commented Dec 7, 2022

Quick summary

When the Table of Contents block is nested inside a column, it's throwing an unexpected error in the editor: This block contains unexpected or invalid content.

Markup on 2022-12-07 at 16:32:42

This stops the block from updating to match the page.

Steps to reproduce

  1. On a new page or post, add the Table of Contents block, along with a couple Heading blocks to give the TOC block something to reference.
  2. Publish the page and refresh.
  3. Next, add a columns block, and place the TOC block inside the Columns block.
  4. Update the page, and refresh once more.

What you expected to happen

The block to not break when nested.

What actually happened

The block displays the unexpected error. Selecting Attempt Block Recovery fixes, but the issue returns the next time you load the editor.

Example

Screen.Capture.on.2022-12-07.at.16-19-04.mp4

⚠️ Impact - If the user does not select Attempt Block Recovery, the TOC block will not update to reflect new changes on the page.

Screen.Capture.on.2022-12-07.at.16-38-35.mov

Selecting ... and Resolve Shows:

Screen Shot 2022-12-07 at 4 18 35 PM

From there, selecting Convert to Blocks changes the Table of Contents into a Static list, which no longer automatically updates, so it's feasible that users will end up breaking their TOC's automatic workings while trying to resolve this issue.

Context

Came up while helping this user create a page with a 2-column layout and Table of Contents blocks in their right-hand sidebar: 38414229-hc

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

Not Theme-Specific.

Tested on Simple, using multiple themes: Twenty Twenty, Penscratch 2

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No but the platform is still usable

Workaround details

There's no alternative way to add the TOC block to a column and prevent that error from appearing. The user will need to select Attempt Block Recovery every time they update their page.

@cuemarie cuemarie added [Type] Bug User Report This issue was created following a WordPress customer report labels Dec 7, 2022
@cuemarie cuemarie changed the title [Block] Table of Contents: Unexpected Error when nested inside columns [Block] Table of Contents: Block Error when nested inside columns Dec 7, 2022
@cuemarie
Copy link
Author

📌 SCRUBBING : RESULT

  • Tested on P2: Replicated
  • Tested on Simple: Replicated
  • Tested on AT: Could Not Replicate
  • Tested on Self-hosted: Could Not Replicate
  • Replicable on Core? No

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I'm still able to replicate the issue above on both P2 and Simple test sites. AT and Self-Hosted do not encounter the same problem.

Example

Markup on 2022-12-13 at 15:36:09

Markup 2022-12-13 at 15 35 10

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

@cuemarie cuemarie added Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. Triaged To be used when issues have been triaged. labels Dec 13, 2022
@kathrynwp
Copy link
Member

I've run into this bug numerous time on P2s, and it's a real issue. :) Would be awesome if anyone were able to take a look.

@Joshgrygiel
Copy link

Another report here: 40187890-hc

User's site is AT and the error is apparent after nesting numerous columns within additional columns

@aleone89
Copy link

aleone89 commented May 5, 2023

@cuemarie
Copy link
Author

Still able to replicate this on my Simple site:

fEYGpj.png

@cuemarie
Copy link
Author

cuemarie commented Jul 27, 2023

Still reproducing on simple sites, however theres not a lot of traction or user reports of this issue, so I think we can safely lower the priority on this to Normal for now.

@cuemarie cuemarie changed the title [Block] Table of Contents: Block Error when nested inside columns [Block] Table of Contents: Block Error when nested inside columns on Simple sites Jul 27, 2023
@eduardozulian
Copy link
Member

eduardozulian commented Feb 8, 2024

I confirmed we can reproduce the issue if you replace the Columns with the Media & Text block. As per the original report, this only happens on simple sites.

This was reported on 7617764-zen, which is related to a longer conversation in p58i-gz0-p2

Captura de Tela 2024-02-08 às 18 51 36

Pinging @cuemarie in case you believe this is something we should prioritize.

Copy link

github-actions bot commented Feb 8, 2024

Support References

This comment is automatically generated. Please do not edit it.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 8, 2024
@jp-imagines
Copy link

Came across this in 7830208-zd-a8c and replicated on a test site as well. In this case, the Table of Contents blocks throw the unexpected or invalid content error when nested even in just a Group block.

@cuemarie
Copy link
Author

Hey @eduardozulian , thanks for the ping and apologies for my delayed response! While this only impacts simple sites who arrange their TOCs this way, I think the issue has the potential to be quite inconvenient for those specific folks.

This was deprioritized from High to Normal in June 2023 to align with internal Dotcom goals at the time. I'm not involved in issue prioritization anymore, but my 2 cents is that "Normal" is still the right priority level, given the low number of customer reports and workaround availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Simple [Pri] Normal Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

6 participants