Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbum: Focus State on Comment Block missing styling #83680

Closed
kraftbj opened this issue Oct 31, 2023 · 3 comments
Closed

Verbum: Focus State on Comment Block missing styling #83680

kraftbj opened this issue Oct 31, 2023 · 3 comments
Labels
Accessibility (a11y) [Feature] Comments Comments on posts and the admin screen for managing them. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Platform] Atomic [Platform] Simple [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Oct 31, 2023

Quick summary

Hi there!
I'd like to flag an A11y issue I think I have picked up with the comment block.

If you click into the comment block, and press tab, I would expect there to be a focus state where you can see what element is selected.

This seems to be missing at the moment for the account/gravatar link, the submit comment link (and possibly others - it's hard to tell).

You can test this on:

https://ma.tt/2023/10/texts-joins-automattic/
https://writerbeware.blog/2023/10/20/why-writer-beware-doesnt-recommend-or-endorse-agents-or-publishers/
https://wordpress.com/blog/2023/10/18/introducing-command-palette/ 

On all three examples (on different hosts/platforms) - the issue is there.

Here is a video recording:

tYCEZ9.mp4

I press tab 4x times, and it only shows on the 4th link, when the focus state for "Get Started" is selected, in the block below.

Steps to reproduce

see video above

What you expected to happen

..

What actually happened

..

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

copying it over from https://core.trac.wordpress.org/ticket/59747

@kraftbj kraftbj added [Type] Bug Needs triage Ticket needs to be triaged labels Oct 31, 2023
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Atomic [Platform] Simple [Pri] High labels Oct 31, 2023
@cuemarie cuemarie added [Pri] Normal Accessibility (a11y) [Feature] Comments Comments on posts and the admin screen for managing them. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. and removed [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Pri] High labels Oct 31, 2023
@cuemarie
Copy link

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO
I can replicate this somewhat – inconsistent results:

Firefox – User Settings Open

  • most items show focus state, except:
    • log out link
    • gravatar/user settings button
nyjtay.mp4

Firefox – User Settings Closed

  • 3 tabs to get to Reply
YfrMDD.mp4

Chrome

  • _most items show focus state, except:
    • gravatar/user settings
t02rvq.mp4

Chrome – User Settings Closed

  • 4 tabs to get to Reply, and you can see that the Logout link is highlighted
iR8hnU.mp4

📌 ACTIONS

  • Triaged

@cuemarie
Copy link

FYI @Automattic/vertex

@cuemarie cuemarie added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 31, 2023
@alshakero
Copy link
Member

Hi everyone! Closing as fixed on Nov 2nd.

Fix was here: D127560-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility (a11y) [Feature] Comments Comments on posts and the admin screen for managing them. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Platform] Atomic [Platform] Simple [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

3 participants