Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden blocks in editor for a8c accounts: continue investigation on P2 editor #89795

Open
miksansegundo opened this issue Apr 23, 2024 · 2 comments
Labels
Lego Maintenance Triaged To be used when issues have been triaged. [Type] Bug

Comments

@miksansegundo
Copy link
Collaborator

What

We pushed D145819-code for code that seems to affect only the core editor.

Core Editor P2 editor
Image Image

Why

I am not 100% sure how those blocks are hidden in the P2 editor that opens in a modal. We want to understand how that works to ensure the issue is fixed.

I believe the P2 editor is doing it in the right way because the P2 is not using the following code, which we assume caused the issue.

// Remove any ignored blocks
wp.domReady( () => {
  ignoreBlocks.forEach( wp.data.dispatch( "core/edit-post" ).hideBlockTypes );
} );

How

Investigate the following in wpcom repo:

  • disallowBlocks and hiddenBlockTypes
  • the filter p2editor_settings
  • the function get_p2editor_settings

cc: @taipeicoder

@mrfoxtalbot
Copy link

Thank you for looking into this. I am going to drop a link to the Slack conversation to provide more context in case someone runs into this in the future. p1708980801936029-slack-C0160HSMDQV

@mrfoxtalbot mrfoxtalbot added the Triaged To be used when issues have been triaged. label Apr 26, 2024
@miksansegundo
Copy link
Collaborator Author

Moving to in progress because we have added a server-side log to track this issue. See pbxlJb-5Kl-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lego Maintenance Triaged To be used when issues have been triaged. [Type] Bug
Projects
Development

No branches or pull requests

2 participants