Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You must be an administrator to restore this site #89826

Open
arinoch opened this issue Apr 24, 2024 · 9 comments
Open

You must be an administrator to restore this site #89826

arinoch opened this issue Apr 24, 2024 · 9 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Enhancement

Comments

@arinoch
Copy link

arinoch commented Apr 24, 2024

Quick summary

self-service site restores fail with error: "you must be an administrator to restore this site"

Steps to reproduce

  1. Delete a site.
  2. Then try to restore it from https://wordpress.com/sites

What you expected to happen

As a user, I should be able to restore a site.

What actually happened

We're getting reports that users are not able to, as in 8086469-zd-a8c.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

Accessing the blog RC, there is no owner information on the deleted site. The system guesses who the owner is when the site is restored and an administrator is assigned. The HE must manually restore the site.

@arinoch arinoch added [Type] Bug [Feature] Site Settings All other general site settings. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. labels Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8086469-zen
  • 8106337-zen
  • 8132488-zen
  • 8145699-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 24, 2024
@mrfoxtalbot
Copy link

Thank you for the report, @arinoch.

I am not sure if this would fall under "bug" or under "product decision". Should non-admin users be able to restore a site that has been deleted by an admin? Who should have the last word in this scenario?

I am going to relabel this as "Enhancement" for now but please feel free to comment if you have some insights or rationale you would like to share.

Thanks again!

@mrfoxtalbot mrfoxtalbot added [Type] Enhancement [Pri] Low [Status] Needs Author Reply Triaged To be used when issues have been triaged. and removed [Type] Bug [Pri] Normal Needs triage Ticket needs to be triaged labels Apr 26, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 26, 2024

One more thought, @arinoch. If an admin deletes a site, they will be removed. What happens then if an editor wants to reopen the site?

Should the old admin who deleted the site get re-added? Should the editor who restored the site be bumped to admin? I see this as problematic... I am going to actually close this as wontfix but please feel free to reopen if you want to continue exploring this.

Thanks again, James!

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
@ha-un
Copy link
Collaborator

ha-un commented Apr 29, 2024

Hi @mrfoxtalbot - to answer your question, an editor should not have permission to delete a site. Only admins and site owners.

Currently, both admins and site owners can delete a site, but only the original owner (site owner) can restore, and it should remain that way because we have to go through a series of steps if a non-site owner admin requests a site to be restored: PaIqia-6p-p2

The problem we're seeing is that sometimes, site owners cannot restore their site and they see a Only an administrator can restore a deleted site. error.

Example: 8106337-zd-a8c

Note: I'll keep this closed for now, but if there are more reports please re-open!

@arinoch arinoch reopened this May 6, 2024
@arinoch
Copy link
Author

arinoch commented May 6, 2024

Reopening this as we've got another report in 8132488-ZD

@philnick206
Copy link

I see this same issue in 8145699-zd-a8c

The issue is that the site they are trying to restore via /sites is showing as a Deleted Site, but it isn't. The user renamed the site (i.e. changed the subdomain address of the site), and this had the effect of deleting the site with the old name and creating a new one in the system, as well as showing the same thing to the user in /sites. If the user tried to restore this "deleted site", they receive the error that Only an administrator can restore a deleted site.

So it looks like, at least in my case, the renamed site should never be shown as one that can be restored in their list of sites under /sites. I'm not sure if this is the same bug or a separate bug, but I'll leave this here for additional investigation.

@arinoch
Copy link
Author

arinoch commented May 9, 2024

@philnick206, that's a related but not the same bug. Previously sites were not renamed, but were deleted.

@ha-un
Copy link
Collaborator

ha-un commented May 12, 2024

This could be from the following change: p1715280145550409-slack-CB0B2G43X
Asked to confirm.

@mpkelly
Copy link
Contributor

mpkelly commented May 14, 2024

Hi, @arinoch and @philnick206. This is a temporary issue that affects some sites that were deleted 30 days before this change, p1715280145550409-slack-CB0B2G43X, on May 9th.

This could be from the following change: p1715280145550409-slack-CB0B2G43X
Asked to confirm.

Yes, that was it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] Site Settings All other general site settings. [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Enhancement
Projects
Development

No branches or pull requests

5 participants