Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic: file-editor-warning buttons misaligned #90177

Open
cuemarie opened this issue May 1, 2024 · 3 comments
Open

Atomic: file-editor-warning buttons misaligned #90177

cuemarie opened this issue May 1, 2024 · 3 comments
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Other Atomic Infrastructure Anything else related to Atomic. [Platform] Atomic [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@cuemarie
Copy link

cuemarie commented May 1, 2024

Quick summary

The "Go Back" and "I Understand" buttons included in the file-editor-warning when navigating to Theme File Editor or Plugin File Editor are misaligned.

Steps to reproduce

  1. Open a new Atomic Site
  2. Navigate to /wp-admin/plugin-editor.php or /wp-admin/theme-editor.php for the first time

What you expected to happen

The pop up's buttons to be aligned

What actually happened

The buttons are misaligned. It looks like the "I understand" dismiss button has a specific vertical alignment (baseline) that's not applying to the first button:

.wp-core-ui p .button {
  vertical-align: baseline;
}

CleanShot 2024-05-01 at 13 12 16@2x

Impact

All

Available workarounds?

There is no user impact

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

@cuemarie cuemarie added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Other Atomic Infrastructure Anything else related to Atomic. labels May 1, 2024
@liviopv
Copy link

liviopv commented May 2, 2024

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Plugin editor
CleanShot 2024-05-02 at 11 28 43@2x

theme editor

CleanShot 2024-05-02 at 11 29 25@2x

local site
CleanShot 2024-05-02 at 11 30 50@2x

📌 ACTIONS

  • Triaged

@mrfoxtalbot could this be a side-effect of UCNR? Maybe a component changed and affected the button alignment?

@liviopv liviopv added [Pri] Low Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged [Pri] Normal labels May 2, 2024
@mrfoxtalbot
Copy link

I do not know but @Automattic/explorers might be able to confirm.

@allilevine
Copy link
Member

I do not know but @Automattic/explorers might be able to confirm.

This pre-dates the project but we should fix it. I added it to the project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] Other Atomic Infrastructure Anything else related to Atomic. [Platform] Atomic [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Projects
Development

No branches or pull requests

4 participants