Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Check the calypso warning "WARN calypso: Route already set up. Ambiguous route definition likely." #90434

Open
bogiii opened this issue May 8, 2024 · 3 comments

Comments

@bogiii
Copy link
Contributor

bogiii commented May 8, 2024

No description provided.

@TimBroddin TimBroddin self-assigned this May 10, 2024
@TimBroddin
Copy link
Contributor

Possibly because we mark site_slug as optional here:

/${ langParam }/plugins/scheduled-updates/:site_slug?

	if ( isEnabled( 'plugins/multisite-scheduled-updates' ) ) {
		router(
			[
				`/${ langParam }/plugins/scheduled-updates`,
				`/${ langParam }/plugins/scheduled-updates/:action(create)`,
				`/${ langParam }/plugins/scheduled-updates/:action(edit)/:id`,
			],
			redirectLoggedOut,
			navigation,
			scheduledUpdatesMultisite,
			makeLayout,
			clientRender
		);
	}

	router(
		[
			`/${ langParam }/plugins/scheduled-updates/:site_slug?`,
			`/${ langParam }/plugins/scheduled-updates/:action/:site_slug?`,
			`/${ langParam }/plugins/scheduled-updates/:action/:site_slug?/:schedule_id`,

Checking to see if it goes away and nothing breaks when making at mandatory.

@TimBroddin
Copy link
Contributor

Still happens when a required site_slug

@TimBroddin
Copy link
Contributor

Related PR where we fixed it before: https://github.com/Automattic/wp-calypso/pull/88454/files

@TimBroddin TimBroddin removed their assignment May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants