Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: Storage volume rendered for spotlight plan not reflecting purchased storage #90949

Closed
chriskmnds opened this issue May 21, 2024 · 3 comments · Fixed by #91050
Closed
Labels
Needs triage Ticket needs to be triaged Storage Addon

Comments

@chriskmnds
Copy link
Contributor

chriskmnds commented May 21, 2024

@jeyip do we have an issue for the storage shown for spotlight/current plan not reflecting the real/actual storage after additional storage purchased? e.g. this is what's shown for a site on a Creator plan that I just purchased additional 150GB storage through the add-ons page (shouldn't it be 200, and not 50?):

Screenshot 2024-05-21 at 3 49 41 PM

Originally posted by @chriskmnds in #90664 (comment)

@chriskmnds
Copy link
Contributor Author

cc @southp @jeyip can you please confirm here as well what the situation above should be?

@chriskmnds chriskmnds added Storage Addon Needs triage Ticket needs to be triaged labels May 21, 2024
@chriskmnds chriskmnds changed the title Plans: Storage volume rendered for spotlight plan not reflecting purchased storage add-on's Plans: Storage volume rendered for spotlight plan not reflecting purchased storage May 21, 2024
@southp
Copy link
Contributor

southp commented May 24, 2024

Great question.
From what I recall, it used to be the dropdown that preselected the purchased one with the lower storage options filtered out. That created a weird situation that a site on 200G would see a dropdown having only one item though 🤷🏼‍♂️

However, I think we will need to resolve this issue first before bringing that back. Otherwise the dropdown simply won't work. Otherwise, I'd suggest us to just show a label of "100G", "200G", etc. when they have purchased a storage add-on already.

@chriskmnds
Copy link
Contributor Author

chriskmnds commented May 24, 2024

👋 @southp

However, I think we will need to resolve this issue first before bringing that back. Otherwise the dropdown simply won't work.

I replied here: #86150 (comment)
We need to check backend restrictions etc. I think the UI is worked out in a way to show valid purchase add-ons i.e. an extra 100 over the 50 purchased would violate some conditions.

Otherwise, I'd suggest us to just show a label of "100G", "200G", etc. when they have purchased a storage add-on already.

Yep, this is what's done in #91050 (show the combined). Main question is whether the plan price should also reflect the additional yearly cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged Storage Addon
Projects
None yet
2 participants