Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced Jetpack connection short check from 2 minutes to 15 seconds #91049

Merged
merged 1 commit into from
May 23, 2024

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented May 23, 2024

Related to #90758 (comment)

Diff related: D149747-code

Proposed Changes

  • We're reducing the time check for broken Jetpack connections

Why are these changes being made?

  • Users are reaching HE with a broken Jetpack warning, although it's already fixed by Jetpack itself.

How to test?

  • Apply this diff and follow its test steps: D149747-code

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/jetpack-connection-short-check on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 self-assigned this May 23, 2024
@paulopmt1 paulopmt1 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2024
@paulopmt1
Copy link
Contributor Author

Validated here: D149747-code

@paulopmt1 paulopmt1 merged commit 3382330 into trunk May 23, 2024
16 checks passed
@paulopmt1 paulopmt1 deleted the update/jetpack-connection-short-check branch May 23, 2024 18:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants