Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to unlock blocks #91273

Closed
rickmgithub opened this issue May 30, 2024 · 7 comments
Closed

Impossible to unlock blocks #91273

rickmgithub opened this issue May 30, 2024 · 7 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@rickmgithub
Copy link

Quick summary

In the site editor it is not possible to change the order of the content within the content block. Blocks are locked and can't be unlocked.
This (p1717024263619579/1716990789.031319-slack-C03TY6J1A) indicates that the locking feature is going to be removed but will that mean blocks can be moved or not?

Steps to reproduce

  1. Simple site with Creatio 2
  2. Create a page in the site editor
  3. Here is the scenario I tried but you can see the locked block within the content block immediately
    Markup on 2024-05-30 at 16-46-30
  4. Noticed the blocks are locked
  5. Try to unlock them and you can't. Try to change the order of the blocks and you can't.
  6. Replicated this on a test site with two different themes

I'm not sure if this is intended but it's a confusing user experience at the least.

What you expected to happen

The blocks to unlock and then to be able to move the order of blocks within the content block in the site editor

What actually happened

Can't unlock the blocks

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

8252965-zd-a8c

@rickmgithub rickmgithub added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels May 30, 2024
Copy link

github-actions bot commented May 30, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8252965-zen
  • 8250080-zen
  • 8274586-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label May 30, 2024
@mrfoxtalbot
Copy link

I cannot repro (or maybe I do not understand)

You can unlock from the three-dot menu in the List View or via the block toolbar itself:

Kapture.2024-06-07.at.17.32.04.mp4

Would this make sense? I am going to close this as "cannot repro" but please feel free to re-open it if this was not what you meant. Thank you

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@mrfoxtalbot mrfoxtalbot added Triaged To be used when issues have been triaged. [Closed] Not Reproducible Issue cannot be reproduced. and removed Needs triage Ticket needs to be triaged labels Jun 7, 2024
@ha-un
Copy link

ha-un commented Jun 8, 2024

Hi @mrfoxtalbot - this happens within the "Pages" section of the Site Editor (in the individual pages), instead of the Page Template, which I'm assuming is where you were when recording the video!

A similar case would be the "Navigation" section. If you go to Navigation → click on the three vertical dots next to the menu name → click on "Edit" the order of the navigation items are locked and cannot be removed.

8250080-zd-a8c

Here are example videos of both cases:

Locked blocks in pages

CleanShot.2024-06-08.at.16.37.27.mp4

Locked blocks in navigation

CleanShot.2024-06-08.at.16.38.36.mp4

@ha-un ha-un reopened this Jun 8, 2024
@arinoch
Copy link

arinoch commented Jun 9, 2024

I opened #91624 but realize it might be related to this one as well. In case you wanted another test, @mrfoxtalbot.

@liviopv
Copy link

liviopv commented Jun 10, 2024

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated / Could Not Replicate / Uncertain
  • Replicable outside of Dotcom – Yes/No

📌 FINDINGS/SCREENSHOTS/VIDEO
Simple - GB 18.4.1
https://github.com/Automattic/wp-calypso/assets/14153300/f1f56dde-63ac-44cc-98a6-928d0272dda8

Simple - GB 18.5 RC - fixed ✅
CleanShot 2024-06-10 at 16 03 52@2x

Atomic - GB 18.4.1
CleanShot 2024-06-10 at 16 07 04@2x

Local site - GB 18.4.1
CleanShot 2024-06-10 at 16 06 20@2x

📌 ACTIONS

  • Triaged

This will be fixed by Gutenberg 18.5, which has already been released and it will be deployed to WordPress.com in the next few days.

@liviopv liviopv added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Platform] Atomic [Pri] High and removed [Closed] Not Reproducible Issue cannot be reproduced. [Pri] Low labels Jun 10, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jun 10, 2024
@nazilya06
Copy link

Another report: 8274586-zd-a8c

@liviopv
Copy link

liviopv commented Jun 20, 2024

18.5 is now running on both Simple and Atomic, so I'm closing this.

@liviopv liviopv closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

6 participants