Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Management Panel and Jetpack Dashboard Issues as an Editor using wp-admin #91920

Closed
sajmes opened this issue Jun 18, 2024 · 2 comments
Closed
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@sajmes
Copy link

sajmes commented Jun 18, 2024

Quick summary

If an admin is switched to an editor role on a site, and they previously used the wp-admin view, they cannot change this back to the WordPress.com view.

From the wp-admin view as an Editor:

They also will continue to see the Site Management Panel on the dashboard. When clicking links there, those options attempt to load then return the user to the dashboard.

For all editors, the Jetpack settings appear incorrectly. When clicking 'Dashboard', the left sidebar highlights 'Settings' but displays a blank dashboard screen. When changing to the 'Settings' option, the left sidebar no longer highlights 'Settings'.

Steps to reproduce

  1. Invite a user to a site as an admin and change their view to wp-admin
  2. Change their role to Editor
  3. Attempt to load the site management panel links and/or Jetpack dashboard.

What you expected to happen

No option to see site management panel as an Editor, or at least a 'you need different permissions' message.

Jetpack to load the dashboard and to correctly show the settings/dashboard highlighted in the left sidebar.

What actually happened

For site management panel links, the links attempt to load then return user to the dashboard.

For Jetpack, the Jetpack settings appear incorrectly. When clicking 'Dashboard', the left sidebar highlights 'Settings' but displays a blank dashboard screen. When changing to the 'Settings' option, the left sidebar no longer highlights 'Settings'.

CleanShot 2024-06-18 at 15 44 19 (1)

Impact

Some (< 50%)

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@sajmes sajmes added [Type] Bug [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. labels Jun 18, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Pri] BLOCKER labels Jun 18, 2024
@liviopv
Copy link

liviopv commented Jun 19, 2024

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • The "Site Management Panel" loaded for me after switching the account to Editor, and links to Dev Tools simply reloaded the page
  • Jetpack items were listed, but with limited functionality. It makes sense to keep the Social settings, but I have no idea why Security > Brute force protection is shown there
CleanShot.2024-06-19.at.11.23.41.mp4

📌 ACTIONS

  • Triaged

Pinging @mrfoxtalbot as this sounds like a gap due to UCNR.

@liviopv liviopv added [Pri] Normal Triaged To be used when issues have been triaged. [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. and removed [Pri] BLOCKER Needs triage Ticket needs to be triaged [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Jun 19, 2024
@mrfoxtalbot
Copy link

The interface preference is per-site, not per user so it makes sense that we limit it to Admins.

Hiding menu items for users who lack permission to manage them is the default behavior so that's expected too.

I am going to close this one but please feel free to re-open and comment if I misunderstood. something.

Thanks again for reporting!

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

3 participants