Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Woo registration does not work for marketplace woo products #91969

Closed
gavande1 opened this issue Jun 20, 2024 · 3 comments
Closed
Assignees
Labels
[Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. Marketplace [Platform] Atomic [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@gavande1
Copy link
Contributor

gavande1 commented Jun 20, 2024

Quick summary

The woo registration for marketplace products is not working for atomic sites. Due to this, the customers cannot use the product after purchasing it. It asks the user to buy a license when the customer visits the extension page in WP admin.

Steps to reproduce

  1. Get an atomic test site with entrepreneur plan
  2. Purchase Tipping WooCommerce from the marketplace
  3. Check if the plugin is installed
  4. Go to Extensions > Manage and see if the plugin shows under a valid Installed Extensions without a Subscription header.

What you expected to happen

The plugin shows under Subscription header and should be valid and registered with Woo when you visit Extensions > Manage. `

What actually happened

The plugin shows under Installed Extensions without a Subscription and asks me to buy a subscription with Woo when I visit Extensions > Manage.

Impact

One

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Slack Convo: p1718824633269259-slack-C029JEQRVRT

@gavande1 gavande1 added [Type] Bug [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. labels Jun 20, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jun 20, 2024
@gavande1 gavande1 added Marketplace and removed Needs triage Ticket needs to be triaged [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. labels Jun 20, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jun 20, 2024
@gavande1 gavande1 reopened this Jun 20, 2024
@gavande1
Copy link
Contributor Author

gavande1 commented Jun 20, 2024

The store_vendor_products table seems to have an incorrect vendor ID for the product. The Woo registration happens only when the product belongs to the Woo vendor. The change needs to occur in the codebase specifically to how we check if products need to be registered on Woo or not.

The Marketplace_Product_Catalog::is_woocommerce_product() returns false for the Tipping for WooCommerce plugin, while it should return true if we expect it to register on Woo.

@gavande1 gavande1 added the Triaged To be used when issues have been triaged. label Jun 20, 2024
@gavande1
Copy link
Contributor Author

Diff created to fix the issue: D152977-code

@gavande1 gavande1 self-assigned this Jun 21, 2024
@gavande1 gavande1 added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts and removed [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Jun 21, 2024
@gavande1
Copy link
Contributor Author

The fix was deployed in r298112-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. Marketplace [Platform] Atomic [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

1 participant