Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People can't hear each other while talking on radio #35

Closed
MatinHQ opened this issue Mar 21, 2021 · 17 comments
Closed

People can't hear each other while talking on radio #35

MatinHQ opened this issue Mar 21, 2021 · 17 comments

Comments

@MatinHQ
Copy link
Contributor

MatinHQ commented Mar 21, 2021

Describe the bug
I just updated pma-voice to the latest commit, and now when players go in the same radio frequency they barely can hear each other

https://youtu.be/WqC5U4O5WmM
To Reproduce
Steps to reproduce the behavior:

  1. Go on the same radio frequency
  2. Hold M and start to talk
  3. If you are not near the player you both can't hear each other

Expected behavior
Players must hear each other when they are on the same radio frequency

Server Info:

  • Server Version: FXServer-master v1.0.0.3648 linux
  • Client Version: Stable

Additional context
I modified pma-voice for my own use if it's needed I can send it

server.cfg
setr voice_useSendingRangeOnly true setr voice_use3dAudio true setr voice_zoneRadius 12

@AvarianKnight
Copy link
Owner

@MatinHQ
Copy link
Contributor Author

MatinHQ commented Mar 21, 2021

Somehow is still broken when you try to talk on radio or phone call when you are not nearby player, I put convars I am using on video description for this test https://www.youtube.com/watch?v=bukgFupCK2k

also when I am not using native audio it's the same when I am not near the player I can't hear him on radio/phone

@ResqDiver1317
Copy link

We are having the same issue. Sometimes we can hear the mic chirps, but most of the time we cannot hear the actual talking over the radio at all. Sometimes it seems it will come in and work fine for a few minutes but most of the time it just doesn't work. I found this issue and updated to the new version today and it's still the same issue.

@AvarianKnight
Copy link
Owner

I will be releasing an update whenever I can find the cause of the issue.

@AvarianKnight
Copy link
Owner

Try this instead, I pray that it works D: https://github.com/AvarianKnight/pma-voice/releases/tag/v3.1.0

@ejayxyz
Copy link

ejayxyz commented Mar 22, 2021

First of all, thanks for the Great job guys! The phone is working perfectly for us, but on the Radio, only 1 player can talk at the same time. If someone is talking, and an another guys presses the button, and start talking, we cant hear the previous one. But I'll try this release.

@ejayxyz
Copy link

ejayxyz commented Mar 22, 2021

Feedback: we are using ls-radio, and when we are connecting, the ui doesnt triggers the radio, and we cant even hear each other nor the mic clicks. (in the 3.1 version)

@MatinHQ
Copy link
Contributor Author

MatinHQ commented Mar 22, 2021

Try this instead, I pray that it works D: https://github.com/AvarianKnight/pma-voice/releases/tag/v3.1.0

First of all, I want to thank you because of your quick response, thanks for hearing out the issues and fixing them!

For now radio, phone, proximity it's 100% fixed and stable, however, I just test that with around 5 players, today I am going to push 3.1.0 update to the main server and see the result and I will share feedback

However, there is only one issue now, voice volume is really low when you are using native audio and I fixed that by setting the default voice volume to something higher but this error will pop up when I hold the radio button
image

@MatinHQ
Copy link
Contributor Author

MatinHQ commented Mar 22, 2021

And there is a big issue with 3.1.0 go near someone and join a radio channel or call channel, start talking and no one expects those people who are on that channel can hear you (Players who are near you must hear you) + afterwards when you stop talking on the radio/call they still can't hear you unless you use /vr command

@AvarianKnight
Copy link
Owner

It's something currently known, sadly wont have time to try and fix it till later tonight

@AvarianKnight
Copy link
Owner

AvarianKnight commented Mar 23, 2021

image

It only takes a value between 0.0 and 1.0 IIRC, you can use setr voice_defaultVolume 0.6 on the latest pre-release which should fix some of the other issues listed here (hopefully), please share if you're still having the issues, as I can't reproduce the issue at all anymore (though its only me and a second client).

@MatinHQ
Copy link
Contributor Author

MatinHQ commented Mar 23, 2021

there was an error, I don't know what triggered that error because I notice that when I was going to leave the server

image
There is a line miss-match because I modified some stuff (not core functions)

image

Also, NetworkIsPlayerTalking(player), seems doesn't work accurately since 3.1.0 update

and some players are complaining about when they release the radio button, some players on the radio are still able to hear what they are saying after 3-4 second for phone calls is also same but it will last for up to 10 seconds

@AvarianKnight
Copy link
Owner

there was an error, I don't know what triggered that error because I notice that when I was going to leave the server

image
There is a line miss-match because I modified some stuff (not core functions)

--SNIP--

Also, NetworkIsPlayerTalking(player), seems doesn't work accurately since 3.1.0 update

and some players are complaining about when they release the radio button, some players on the radio are still able to hear what they are saying after 3-4 second for phone calls is also same but it will last for up to 10 seconds

Not sure why you would be the only one to have this issue, can you please make sure you're sending a table as the targets, seems you might've modified your pma-voice and that would cause the issue

Nothing has changed with NetworkIsPlayerTalking so that's weird.

@MatinHQ
Copy link
Contributor Author

MatinHQ commented Mar 24, 2021

Hello again, I didn't edit core functions, events at all and I did more digging and that error pops up when you end your call with someone, and it's the version of pma-voice I modified

pma-voice.zip

@AvarianKnight
Copy link
Owner

Hello again, I didn't core functions, events at all and I did more digging and that error pops up when you end your call with someone, and it's the version of pma-voice I modified

pma-voice.zip

You're right, I think I might've found the issue.

@AvarianKnight
Copy link
Owner

@AvarianKnight
Copy link
Owner

Going to close this as it should be resolved in the latest commit, if you have other issues feel free to open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants