Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Response instead of Void for "Sales and Finance Reports" endpoints #100

Closed
kinnarr opened this issue May 9, 2020 · 2 comments · Fixed by #103
Closed

Return Response instead of Void for "Sales and Finance Reports" endpoints #100

kinnarr opened this issue May 9, 2020 · 2 comments · Fixed by #103
Labels
Stale

Comments

@kinnarr
Copy link

kinnarr commented May 9, 2020

I try to get finance reports from API. To get the gzip archive I need access to Response.data which is not provided for APIEndpoints with T == Void.

Is it possible to provide the Response object instead of Void to the completion handler?
@kinnarr kinnarr changed the title Return Respone instead of Void for "Sales and Finance Reports" endpoints Return Response instead of Void for "Sales and Finance Reports" endpoints May 10, 2020
@DechengMa DechengMa mentioned this issue Jun 2, 2020
Merged
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 10, 2020
@SwiftLeeBot
Copy link
Collaborator

The pull request #103 that closed this issue was merged and released as part of Release 1.1.2 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change sales response to data ittybittyapps/appstoreconnect-swift-sdk
2 participants
@kinnarr @SwiftLeeBot