Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming mismatch for include field in Response #86

Closed
DechengMa opened this issue Apr 15, 2020 · 1 comment · Fixed by #87
Closed

Naming mismatch for include field in Response #86

DechengMa opened this issue Apr 15, 2020 · 1 comment · Fixed by #87

Comments

@DechengMa
Copy link
Contributor

Hi there, thanks for the SDK. I just found there are some naming mismatches for struct response, which will lead to response.include returns null

According to the API documentation, the field should be named as follows

include -> included

image
@DechengMa DechengMa mentioned this issue Apr 15, 2020
Merged
@SwiftLeeBot
Copy link
Collaborator

The pull request #87 that closed this issue was merged and released as part of Release 1.0.3 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename include -> included in Response DechengMa/appstoreconnect-swift-sdk
2 participants
@DechengMa @SwiftLeeBot