Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"run dist" does not exist and "run build" errors #28

Closed
thoni56 opened this issue Jul 13, 2020 · 3 comments
Closed

"run dist" does not exist and "run build" errors #28

thoni56 opened this issue Jul 13, 2020 · 3 comments

Comments

@thoni56
Copy link

thoni56 commented Jul 13, 2020

How do I build a distribution of this? When I do

npm run dist

as the README.md says that does not exist. And

npm run build

crashes with

MusicPlayer/node_modules/electron-builder/node_modules/fs-extra/lib/mkdirs/make-dir.js:86
     } catch {
             ^

SyntaxError: Unexpected token {
   at createScript (vm.js:80:10)
   at Object.runInThisContext (vm.js:139:10)
   at Module._compile (module.js:616:28)
   at Object.Module._extensions..js (module.js:663:10)
   at Module.load (module.js:565:32)
   at tryModuleLoad (module.js:505:12)
   at Function.Module._load (module.js:497:3)
   at Module.require (module.js:596:17)
   at require (internal/module.js:11:18)
   at Object.<anonymous> (/home/thoni56/Utveckling/MusicPlayer/node_modules/electron-builder/node_modules/fs-extra/lib/mkdirs/index.js:3:44)
@Aveek-Saha
Copy link
Owner

The command on the readme should be updated to npm run build. However on running npm run build I was unable to recreate the issue.

Are you trying to build from an external drive? If so that might be the issue as indicated here: electron-userland/electron-builder#4045 (comment)

@thoni56
Copy link
Author

thoni56 commented Jul 13, 2020

I removed everything and re-cloned and now it worked so there was probably something wrong with my copy, or something I did when trying variations on "npm run..." until I got the bright idea to look in package.json ;-)

So all is well. After that minor update in the README, of course.

Thanks.

@Aveek-Saha
Copy link
Owner

The README has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants