Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method to add configuration #18

Open
AviKKi opened this issue Oct 22, 2020 · 0 comments
Open

Method to add configuration #18

AviKKi opened this issue Oct 22, 2020 · 0 comments
Labels
enhancement New feature or request hacktober hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed

Comments

@AviKKi
Copy link
Owner

AviKKi commented Oct 22, 2020

Following variables should be configurable

  • class name hover-preview
  • attribute name data-preview
  • constant HOVER_DELAY
  • constant PREVIEW_DURATION

A discussion regarding which method should be best is required.

Suggested method -

  1. defining all the configurations as a json object in document head.
  2. exposing a global variable ex. - HoverPreview with .init method to initialize plugin with all configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktober hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AviKKi