Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Demo in ReadMe #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gilbishkosma
Copy link
Contributor

I have added the demo link in the ReadMe file and also updated the example/index.html file
I have used jsdelivr in order to access the hover-review.minified.js file instead of directly accesing the raw github file.
Cause in 2013, GitHub started using X-Content-Type-Options: nosniff, which instructs more modern browsers to enforce strict MIME type checking. It then returns the raw files in a MIME type returned by the server, preventing the browser from using the file as-intended (if the browser honors the setting).

You can read more about this here

I have used cdn.jsdelivr.net in order to access the hover-preview.min.js file.
Added the demo link
@AviKKi
Copy link
Owner

AviKKi commented Oct 19, 2020

@Gilbishkosma add this link in the readme instead, it looks much better, the example in example directory can serve as an simpler example.

@Gilbishkosma
Copy link
Contributor Author

sure @AviKKi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants