Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Set of Images (single post) Download Issue #172

Open
Oldgit13 opened this issue Oct 24, 2023 · 2 comments
Open

Set of Images (single post) Download Issue #172

Oldgit13 opened this issue Oct 24, 2023 · 2 comments
Labels
needs triage issue needs to be validated

Comments

@Oldgit13
Copy link

Bug Description

Images in a set (single post) are not all being saved correctly with the meta handling set to advanced in the config file.

Expected behavior

Downloads for example 10 images in a 10 image set.

Actual behavior

Downloads 10 of the 10 images but overwrites with varying levels for example 3 of the images leaving 7 saved to disk.

Additional context

So using metadata handling set to advanced in the single post set of images it saves with the date and time "2023-10-24_at_15-47.jpg" sometimes some of the images have the same date and time so it overwrites the first instance of the downloaded file with the same corresponding filename. This does not happen with metadata handling set to simple since it adds the unique identifier to the filename.

@Oldgit13 Oldgit13 added the needs triage issue needs to be validated label Oct 24, 2023
@Oldgit13
Copy link
Author

As a work around for myself I just added the id to the file name on line 720 which has helped.

From - f"{created_at}.{file_extension}" To - f"{created_at}id{media_id}.{file_extension}"

Perhaps some sort of incremental filename index could be useful.

@grummmm
Copy link

grummmm commented Nov 9, 2023

i had the same issue, your fix worked. thank you for sharing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage issue needs to be validated
Projects
None yet
Development

No branches or pull requests

2 participants