I210 implementation + Taprio software support + mapping customization (rebase) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be fully tested later
If no flag entered it should behave like in the past, this file should probably be edited more but need to be able to run the software to figure out a bit more.
renamed the test dealing with the tc command for setting taprio with offload to the appropriate name. it was before called test_iplinksetvlan. I also added a test for tc command dealing taprio software mode(flag)
Just a test thing, will see what I end up using in the end
+ Editing tests to encompass new variables being returned + testing the values of it hardware latency for i225 and rename for i210 small fix
This reverts commit fbe47a5.
This reverts commit 481a795.
This reverts commit 351783f.
This reverts commit 97346a7.
This reverts commit 1d28fd8.
…210 Support + mapping customization
Open
xtor
changed the title
xtor
requested changes
Apr 28, 2024
kamber-intel
force-pushed
the
amb_i20_support
branch
from
02d4da4
to
c2798d6
Compare
kamber-intel
force-pushed
the
amb_i20_support
branch
5 times, most recently
from
0718f62
to
8b9c57c
Compare
kamber-intel
force-pushed
the
amb_i20_support
branch
7 times, most recently
from
4a52ecc
to
963197a
Compare
kamber-intel
force-pushed
the
amb_i20_support
branch
from
963197a
to
fd646d5
Compare
kamber-intel
force-pushed
the
amb_i20_support
branch
3 times, most recently
from
fbe3161
to
52d9511
Compare
xtor
requested changes
Jun 5, 2024
detd/devices/device.py
Outdated
| @@ -22,12 +22,11 @@ | |||
|
|
|||
| from ..logger import get_logger | |||
|
|
|||
| from ..scheduler import TxCapability | |||
There was a problem hiding this comment.
It may be better to leave the "Capability" name. It is true that Qbv and LTC are Tx related, but Qbu (and actually the underlying 802.3br) have also an Rx component.
detd/manager.py
Outdated
|
|
||
| if self.hints.tx_selection == TxCapability.Qbv: |
There was a problem hiding this comment.
Please check the TxSelection description in the ticket.
kamber-intel
force-pushed
the
amb_i20_support
branch
3 times, most recently
from
de9544b
to
9445d35
Compare
xtor
requested changes
Jun 6, 2024
detd/manager.py
Outdated
|
|
||
| if self.interface.device.check_hints(config): | ||
| # Check if the device supports the requested features | ||
| if DataPath(config.hints.data_path) != hints.data_path: |
There was a problem hiding this comment.
The hints have to be checked against the hardware features.
The default hints are a conservative version based on the hardware capabilities. Something may not be set in the default hints that is supported on hardware and hence can be used in some custom hints.
kamber-intel
force-pushed
the
amb_i20_support
branch
3 times, most recently
from
3f40eaa
to
c114c72
Compare
xtor
requested changes
Jun 11, 2024
detd/devices/device.py
Outdated
| raise ValueError(f"Device does not support the requested Tx selection feature." | ||
| f"Requested Tx_selection: {tx_selection}, Requested tx_selection_offload: {tx_selection_offload}") | ||
|
|
||
| if tx_selection == TxSelection.STRICT_PRIO and preemption == True: |
There was a problem hiding this comment.
You do not actually need the STRICT_PRIO part. Preemption can be used in combination with SP but also EST. So perhaps the simplest thing is to check if preemption is requested, and check against the Qbu capability.
detd/devices/intel_i210.py
Outdated
| datapath = DataPath.AF_PACKET | ||
| tx_selection = TxSelection.EST | ||
|
|
||
| if Capability.Qbv in self.capabilities: |
There was a problem hiding this comment.
You can simply set the tx_offload, as within the device plugin you already know what should be offered as the default hints.
detd/devices/intel_i225.py
Outdated
| datapath = DataPath.AF_PACKET | ||
| tx_selection = TxSelection.EST | ||
|
|
||
| if Capability.Qbv in self.capabilities: |
There was a problem hiding this comment.
Same as with i210, you can fix it directly instead of checking against the caps.
detd/devices/intel_mgbeehl.py
Outdated
| datapath = DataPath.AF_PACKET | ||
| tx_selection = TxSelection.EST | ||
|
|
||
| if Capability.Qbv in self.capabilities: |
kamber-intel
force-pushed
the
amb_i20_support
branch
2 times, most recently
from
ec41cda
to
385a7a4
Compare
Signed-off-by: Amber <kumar.amber@intel.com>
kamber-intel
force-pushed
the
amb_i20_support
branch
from
385a7a4
to
8b368a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.